third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h - Issue 2637343002: Implement WebBluetooth descriptor.readValue()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h

Issue 2637343002: Implement WebBluetooth descriptor.readValue() (Closed)

Patch Set: run bad_message_reasons Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h b/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h

index faaee31f312def41f782c4596e32a816f6d5f746..30876f75ee136e8d7f3a7f1bcb3f9f136806a9c0 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h

@@ -61,6 +61,7 @@ class BluetoothDevice final : public EventTargetWithInlineData,

BluetoothRemoteGATTDescriptor* getOrCreateBluetoothRemoteGATTDescriptor(

mojom::blink::WebBluetoothRemoteGATTDescriptorPtr,

BluetoothRemoteGATTCharacteristic*);

+ bool isValidDescriptor(const String& descriptorInstanceId);

// We should disconnect from the device in all of the following cases:

// 1. When the object gets GarbageCollected e.g. it went out of scope.