third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp - Issue 2637343002: Implement WebBluetooth descriptor.readValue()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp

Issue 2637343002: Implement WebBluetooth descriptor.readValue() (Closed)

Patch Set: run bad_message_reasons Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp b/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp

index dde3df2afd038565362397085a5b25020b1684b3..7669ccb13d98f54981810cda3957bbf07ffc36b7 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp

@@ -71,6 +71,10 @@ BluetoothDevice::getOrCreateBluetoothRemoteGATTDescriptor(

std::move(descriptor), characteristic);

}

+bool BluetoothDevice::isValidDescriptor(const String& descriptorInstanceId) {

+ return m_attributeInstanceMap->containsDescriptor(descriptorInstanceId);

void BluetoothDevice::dispose() {

disconnectGATTIfConnected();

}