Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 26373008: Fix a bug which caused crash in SkRTConfig whith string values in environment variables (Closed)

Created:
7 years, 2 months ago by hal.canary
Modified:
7 years, 1 month ago
CC:
skia-review_googlegroups.com, humper
Visibility:
Public.

Description

Fix a bug which caused crash in SkRTConfig whith string values in environment variables A minor change to SkRTConfRegistry::parse() fixes this BUG=skia:1717 R=scroggo@google.com Committed: https://code.google.com/p/skia/source/detail?r=12152

Patch Set 1 #

Patch Set 2 : whitespace change #

Patch Set 3 : simplify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -19 lines) Patch
M src/utils/SkRTConf.cpp View 1 2 3 chunks +10 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hal.canary
7 years, 2 months ago (2013-10-15 21:04:17 UTC) #1
humper
On 2013/10/15 21:04:17, halcanary wrote: lgtm
7 years, 2 months ago (2013-10-15 21:17:56 UTC) #2
hal.canary
On 2013/10/15 21:17:56, humper wrote: > lgtm Greg, I was distracted by some other projects ...
7 years, 1 month ago (2013-10-28 17:17:43 UTC) #3
humper
On 2013/10/28 17:17:43, halcanary wrote: > On 2013/10/15 21:17:56, humper wrote: > > lgtm > ...
7 years, 1 month ago (2013-10-31 16:34:09 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 1 month ago (2013-10-31 16:48:25 UTC) #5
hal.canary
7 years, 1 month ago (2013-10-31 21:11:59 UTC) #6
hal.canary
7 years, 1 month ago (2013-10-31 21:12:32 UTC) #7
scroggo
On 2013/10/31 21:12:32, halcanary wrote: lgtm
7 years, 1 month ago (2013-10-31 21:18:06 UTC) #8
hal.canary
7 years, 1 month ago (2013-11-06 14:18:52 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 manually as r12152 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698