Fix a bug which caused crash in SkRTConfig whith string values in environment variables

src/utils/SkRTConf.cpp

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkRTConf.h"
 #include "SkOSFile.h"
 
@@ skipping 195 matching lines @@
 
 static inline void str_replace(char *s, char search, char replace) {
     for (char *ptr = s ; *ptr ; ptr++) {
         if (*ptr == search) {
             *ptr = replace;
         }
     }
 }
 
 template<typename T> bool SkRTConfRegistry::parse(const char *name, T* value) {
-    SkString *str = NULL;
-    SkString tmp;
+    const char *str = NULL;
 
     for (int i = fConfigFileKeys.count() - 1 ; i >= 0; i--) {
         if (fConfigFileKeys[i]->equals(name)) {
-            str = fConfigFileValues[i];
+            str = fConfigFileValues[i]->c_str();
             break;
         }
     }
 
     SkString environment_variable("skia.");
     environment_variable.append(name);
 
     const char *environment_value = getenv(environment_variable.c_str());
     if (environment_value) {
-        if (NULL == str) {
-            str = &tmp;
-        }
-        str->set(environment_value);
+        str = environment_value;
     } else {
         // apparently my shell doesn't let me have environment variables that
         // have periods in them, so also let the user substitute underscores.
-        SkString underscore_environment_variable("skia_");
-        char *underscore_name = SkStrDup(name);
-        str_replace(underscore_name,'.','_');
-        underscore_environment_variable.append(underscore_name);
-        sk_free(underscore_name);
-        environment_value = getenv(underscore_environment_variable.c_str());
+        SkAutoTMalloc<char> underscore_name(SkStrDup(environment_variable.c_str()));
+        str_replace(underscore_name.get(),'.','_');
+        environment_value = getenv(underscore_name.get());
         if (environment_value) {
-            if (NULL == str) {
-                str = &tmp;
-            }
-            str->set(environment_value);
+            str = environment_value;
         }
     }
 
     if (!str) {
         return false;
     }
 
     bool success;
-    T new_value = doParse<T>(str->c_str(),&success);
+    T new_value = doParse<T>(str, &success);
     if (success) {
         *value = new_value;
     } else {
-        SkDebugf("WARNING: Couldn't parse value \'%s\' for variable \'%s\'\n", str->c_str(), name);
+        SkDebugf("WARNING: Couldn't parse value \'%s\' for variable \'%s\'\n",
+                 str, name);
     }
     return success;
 }
 
 // need to explicitly instantiate the parsing function for every config type we might have...
 
 template bool SkRTConfRegistry::parse(const char *name, bool *value);
 template bool SkRTConfRegistry::parse(const char *name, int *value);
 template bool SkRTConfRegistry::parse(const char *name, unsigned int *value);
 template bool SkRTConfRegistry::parse(const char *name, float *value);
@@ skipping 49 matching lines @@
     sk_setenv("skia_nonexistent_item", "132");
     int result = 0;
     registryWithoutContents.parse("nonexistent.item", &result);
     SkASSERT(result == 132);
 }
 
 SkRTConfRegistry::SkRTConfRegistry(bool)
     : fConfs(100) {
 }
 #endif