Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2637243002: Refactor code in print_settings_intializer_win.cc (Closed)

Created:
3 years, 11 months ago by rbpotter
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor code in print_settings_intializer_win.cc Refactor print settings code in preparation for adding additional checks for printer technology (e.g. postscript support - see https://codereview.chromium.org/2633573002/). BUG=None Review-Url: https://codereview.chromium.org/2637243002 Cr-Commit-Position: refs/heads/master@{#444154} Committed: https://chromium.googlesource.com/chromium/src/+/51933c02c41ba275c28f01981305a6d90ef3f4ce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M printing/print_settings_initializer_win.cc View 1 chunk +17 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
rbpotter
Refactor of print_settings_initializer (separated from large patch).
3 years, 11 months ago (2017-01-17 20:11:14 UTC) #5
Vitaly Buka (NO REVIEWS)
You still can attach original back, to track how we get there. Thanks, LGTM.
3 years, 11 months ago (2017-01-17 20:12:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637243002/1
3 years, 11 months ago (2017-01-17 21:38:59 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 21:44:51 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/51933c02c41ba275c28f01981305...

Powered by Google App Engine
This is Rietveld 408576698