Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2637193002: Support spawnUri in app snapshots. (Closed)

Created:
3 years, 11 months ago by rmacnak
Modified:
3 years, 11 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support spawnUri in app snapshots. - Don't mark core_isolate_snapshot_buffer as a const pointer. - Update app snapshots without code to not rewrite the VM isolate snapshot, as already done by app snapshots with code. Fixes #28368 R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/26a364f9988b502df07b3c633cfc4022e3f28fa5

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -100 lines) Patch
M runtime/bin/main.cc View 13 chunks +60 lines, -22 lines 1 comment Download
M runtime/bin/snapshot_empty.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/snapshot_in.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/lib/isolate.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/service.status View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/tests/vm/vm.status View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/benchmark_test.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/isolate_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/metrics_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/thread_test.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/unit_test.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/zone_test.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/isolate.status View 1 chunk +1 line, -1 line 0 comments Download
M utils/application_snapshot.gni View 1 chunk +0 lines, -45 lines 0 comments Download
M utils/pub/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
https://codereview.chromium.org/2637193002/diff/1/runtime/bin/main.cc File runtime/bin/main.cc (left): https://codereview.chromium.org/2637193002/diff/1/runtime/bin/main.cc#oldcode1526 runtime/bin/main.cc:1526: uint8_t* vm_isolate_buffer = NULL; Rewriting the vm isolate here ...
3 years, 11 months ago (2017-01-17 18:42:22 UTC) #2
siva
lgtm
3 years, 11 months ago (2017-01-17 22:55:00 UTC) #3
rmacnak
3 years, 11 months ago (2017-01-17 23:59:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
26a364f9988b502df07b3c633cfc4022e3f28fa5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698