Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 2637193002: Support spawnUri in app snapshots. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/bin/main.cc ('K') | « runtime/vm/benchmark_test.h ('k') | runtime/vm/dart_api_impl_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc
index 22e23911615cecd9d72dcd545b018d2983ff3b1b..50c30ce8362e632f1cad8107eb37a031f6c4836c 100644
--- a/runtime/vm/dart_api_impl.cc
+++ b/runtime/vm/dart_api_impl.cc
@@ -1581,7 +1581,9 @@ Dart_CreateSnapshot(uint8_t** vm_isolate_snapshot_buffer,
isolate_snapshot_buffer, ApiReallocate,
NULL /* instructions_writer */);
writer.WriteFullSnapshot();
- *vm_isolate_snapshot_size = writer.VmIsolateSnapshotSize();
+ if (vm_isolate_snapshot_buffer != NULL) {
+ *vm_isolate_snapshot_size = writer.VmIsolateSnapshotSize();
+ }
*isolate_snapshot_size = writer.IsolateSnapshotSize();
return Api::Success();
}
« runtime/bin/main.cc ('K') | « runtime/vm/benchmark_test.h ('k') | runtime/vm/dart_api_impl_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698