Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2637183003: Reroute Android mouse events to touch event path. (Closed)

Created:
3 years, 11 months ago by mustaq
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Reroute Android mouse events to touch event path. This is a partial revert of crrev.com/2054193002 that aimed to make Android mouse events more logical & consistent. However, that change made few UI activities impossible through mouse, like text selection, zoom & scrolling. Until we fix those for mouse, we are re-diverting mouse events to the touch-event path through this CL. BUG=678756 Review-Url: https://codereview.chromium.org/2637143002 Cr-Commit-Position: refs/heads/master@{#444116} (cherry picked from commit 8bdf02e2b5552def943a60cf8e078918369df6fe) Review-Url: https://codereview.chromium.org/2637183003 . Cr-Commit-Position: refs/branch-heads/2924@{#784} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/77ddb6126ff2f49a01fec01f80db0d70f5d9213e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 2 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mustaq
3 years, 11 months ago (2017-01-17 21:17:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
77ddb6126ff2f49a01fec01f80db0d70f5d9213e.

Powered by Google App Engine
This is Rietveld 408576698