Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2637133002: Allow load of the chrome://chrome-signin in incognito profile (Closed)

Created:
3 years, 11 months ago by msarda
Modified:
3 years, 11 months ago
CC:
chromium-reviews, anthonyvd, zmin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow load of the chrome://chrome-signin in incognito profile This CL allows to load the chrome://chrome-signin URL in incognito profiles as this is used when unlocking the first time a profile. This basically reverts the change https://codereview.chromium.org/2621083002/ for the chrome://chrome-signin URL as the assumption in that CL was wrong. BUG=681469 Review-Url: https://codereview.chromium.org/2637133002 Cr-Commit-Position: refs/heads/master@{#444107} Committed: https://chromium.googlesource.com/chromium/src/+/5ec1c6df6c10a2eb6911dcf6aa01b5ffcfe6eabe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
msarda
3 years, 11 months ago (2017-01-17 16:19:25 UTC) #2
mahmadi (do not use this)
On 2017/01/17 16:19:25, msarda wrote: lgtm
3 years, 11 months ago (2017-01-17 16:52:26 UTC) #3
msarda
Xiyuan: Please do an owners review for this CL.
3 years, 11 months ago (2017-01-17 18:23:38 UTC) #6
msarda
CC+ zmin@ (FYI) who may have worked on the profile used in the user manager ...
3 years, 11 months ago (2017-01-17 18:25:19 UTC) #7
xiyuan
lgtm
3 years, 11 months ago (2017-01-17 18:27:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637133002/1
3 years, 11 months ago (2017-01-17 18:28:45 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 19:23:51 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5ec1c6df6c10a2eb6911dcf6aa01...

Powered by Google App Engine
This is Rietveld 408576698