Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2637123002: Revert of [complier] Enable parallel eager inner function compilation with compiler dispatcher. (Closed)

Created:
3 years, 11 months ago by Michael Achenbach
Modified:
3 years, 11 months ago
CC:
Michael Hablich, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [complier] Enable parallel eager inner function compilation with compiler dispatcher. (patchset #11 id:260001 of https://codereview.chromium.org/2611313002/ ) Reason for revert: Some crashes on mac: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20-%20debug/builds/11982/steps/Ignition%20-%20turbofan/logs/regress-crbug-429159 https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/10966 Original issue's description: > [complier] Enable parallel eager inner function compilation with compiler dispatcher. > > Enable enqueueing of eager inner function compilation onto the compiler > dispatcher. This enables these tasks to be performed in parallel to > compilation of the outer functio (only for Ignition functions). > We currently synchronize to ensure all inner function compilations > are complete before executing the outer function - future work will > allow outer function execution to happenin parallel to inner function > compilation. > > BUG=v8:5203, v8:5215 > > Review-Url: https://codereview.chromium.org/2611313002 > Cr-Commit-Position: refs/heads/master@{#42413} > Committed: https://chromium.googlesource.com/v8/v8/+/f12661a1ece4e9c9cb8df5c2d349db960356e604 TBR=jochen@chromium.org,marja@chromium.org,mstarzinger@chromium.org,rmcilroy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5203, v8:5215 Review-Url: https://codereview.chromium.org/2637123002 Cr-Commit-Position: refs/heads/master@{#42416} Committed: https://chromium.googlesource.com/v8/v8/+/6715439932eff27c9f06d66d1de1ea4c1232924f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -410 lines) Patch
M src/compiler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 8 chunks +61 lines, -86 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher.h View 5 chunks +3 lines, -24 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher.cc View 8 chunks +14 lines, -85 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-job.h View 5 chunks +4 lines, -16 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-job.cc View 5 chunks +14 lines, -59 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-tracer.h View 4 chunks +0 lines, -4 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-tracer.cc View 5 chunks +4 lines, -20 lines 0 comments Download
M src/flag-definitions.h View 3 chunks +4 lines, -6 lines 0 comments Download
M test/debugger/debug/ignition/debug-step-prefix-bytecodes.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/debugger/debug/ignition/debugger-statement.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/ignition/stack-trace-source-position.js View 2 chunks +4 lines, -3 lines 0 comments Download
M test/mjsunit/regress/regress-618657.js View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc View 8 chunks +3 lines, -10 lines 0 comments Download
M test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc View 2 chunks +0 lines, -95 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [complier] Enable parallel eager inner function compilation with compiler dispatcher.
3 years, 11 months ago (2017-01-17 15:28:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637123002/1
3 years, 11 months ago (2017-01-17 15:28:35 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 15:28:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/6715439932eff27c9f06d66d1de1ea4c123...

Powered by Google App Engine
This is Rietveld 408576698