Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2637113003: DevTools: dtrun CLI helper (Closed)

Created:
3 years, 11 months ago by chenwilliam
Modified:
3 years, 11 months ago
Reviewers:
allada, luoe, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: dtrun CLI helper This introduces a small CLI wrapper (dtrun) around devtools npm commands. For example, doing "dtrun lint" forwards the command to "npm run lint" as defined in Source/devtools/package.json One-time setup: npm run setup-dtrun Benefits: 1) Can run npm commands anywhere in the chromium repo (not just in devtools subtree) 2) No longer need to pass in the delimiter "--" before the flags Note: Works on Linux and Mac, but no on Windows BUG=682327 Review-Url: https://codereview.chromium.org/2637113003 Cr-Commit-Position: refs/heads/master@{#444573} Committed: https://chromium.googlesource.com/chromium/src/+/67d828ef9b351a52fde60df3bf0cc1326bf2fd69

Patch Set 1 #

Patch Set 2 : better err msg #

Patch Set 3 : rename file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -10 lines) Patch
M third_party/WebKit/Source/devtools/package.json View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/readme.md View 1 chunk +44 lines, -9 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/devtools_run/devtools_run_cli View 1 2 1 chunk +49 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/scripts/devtools_run/package.json View 1 2 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
chenwilliam
PTAL
3 years, 11 months ago (2017-01-17 21:45:22 UTC) #4
allada
lgtm, but can you please be a little more detailed in the description of the ...
3 years, 11 months ago (2017-01-17 22:19:24 UTC) #5
chenwilliam
@pfeldman: ptal
3 years, 11 months ago (2017-01-18 18:31:08 UTC) #10
pfeldman
lgtm
3 years, 11 months ago (2017-01-18 20:15:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637113003/20001
3 years, 11 months ago (2017-01-18 20:30:23 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/344530)
3 years, 11 months ago (2017-01-18 20:39:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637113003/40001
3 years, 11 months ago (2017-01-18 22:56:36 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 00:48:59 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/67d828ef9b351a52fde60df3bf0c...

Powered by Google App Engine
This is Rietveld 408576698