Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2637073002: [ic] Decode offset from the handler word later in store IC dispatcher. (Closed)

Created:
3 years, 11 months ago by Igor Sheludko
Modified:
3 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ic] Decode offset from the handler word later in store IC dispatcher. BUG=v8:5495 Review-Url: https://codereview.chromium.org/2637073002 Cr-Commit-Position: refs/heads/master@{#42401} Committed: https://chromium.googlesource.com/v8/v8/+/19c3c667a6eaf2d8163f69b44a50587d6237026a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/ic/accessor-assembler.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/ic/accessor-assembler-impl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Igor Sheludko
PTAL
3 years, 11 months ago (2017-01-17 11:54:55 UTC) #4
Jakob Kummerow
lgtm
3 years, 11 months ago (2017-01-17 11:59:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637073002/1
3 years, 11 months ago (2017-01-17 12:05:31 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 12:16:37 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/19c3c667a6eaf2d8163f69b44a50587d623...

Powered by Google App Engine
This is Rietveld 408576698