Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2637053002: MD Settings: Add Bluetooth device type icons in device lists. (Closed)

Created:
3 years, 11 months ago by fukino
Modified:
3 years, 11 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Add Bluetooth device type icons in device lists. The mapping from device types to icons is consistent with the Bluetooth list in the system menu. Newly added device icons are copyed from https://github.com/PolymerElements/iron-icons/blob/master/hardware-icons.html with the same id. BUG=681784 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2637053002 Cr-Commit-Position: refs/heads/master@{#444225} Committed: https://chromium.googlesource.com/chromium/src/+/dcd83b32c7de902ee531d61a03762fbde0bc5ac8

Patch Set 1 #

Patch Set 2 : . #

Total comments: 3

Patch Set 3 : Fix an annotation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -2 lines) Patch
M chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html View 1 2 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.js View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/icons.html View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
fukino
Steven, could you take a look? https://codereview.chromium.org/2637053002/diff/20001/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html File chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html (right): https://codereview.chromium.org/2637053002/diff/20001/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html#newcode35 chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html:35: <iron-icon id="check" icon="cr:check" ...
3 years, 11 months ago (2017-01-17 11:24:31 UTC) #3
stevenjb
lgtm w/ comment fix https://codereview.chromium.org/2637053002/diff/20001/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.js File chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.js (right): https://codereview.chromium.org/2637053002/diff/20001/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.js#newcode86 chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.js:86: * @param {!chrome.bluetooth.Device} device @return ...
3 years, 11 months ago (2017-01-17 18:34:44 UTC) #4
fukino
Thanks! https://codereview.chromium.org/2637053002/diff/20001/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.js File chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.js (right): https://codereview.chromium.org/2637053002/diff/20001/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.js#newcode86 chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.js:86: * @param {!chrome.bluetooth.Device} device On 2017/01/17 18:34:44, stevenjb ...
3 years, 11 months ago (2017-01-18 00:07:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637053002/40001
3 years, 11 months ago (2017-01-18 00:08:01 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 01:25:39 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/dcd83b32c7de902ee531d61a0376...

Powered by Google App Engine
This is Rietveld 408576698