Allow shared modules to whitelist extensions that import them.

Allow shared modules to whitelist extensions that import them.

BUG=368713
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267943

[asargent_no_longer_on_chrome, 2014-05-01 17:50:15]

lgtm w/ a few small nits

https://codereview.chromium.org/263703002/diff/1/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/263703002/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:4562: +        Unable to import extension
with ID "<ph name="IMPORT_ID">$1<ex>aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa</ex></ph>"
because it is not allowed by whitelist.
nit: "because it is not allowed by whitelist" doesn't quite read right. Maybe
try something like:

 because it is not allowed by its whitelist 

or

 because it is not allowed by "<ph
name="IMPORT_ID">$1<ex>aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa</ex></ph>"'s whitelist

https://codereview.chromium.org/263703002/diff/1/extensions/common/manifest_h...
File extensions/common/manifest_handlers/shared_module_info.h (right):

https://codereview.chromium.org/263703002/diff/1/extensions/common/manifest_h...
extensions/common/manifest_handlers/shared_module_info.h:40: const std::string&
other_id);
Can you add a comment here mentioning that in the absence of an explicit
whitelist, that exporting to any extension is allowed? (I wondered whether that
was the case when looking at the method signature here, and had to look at the
implementation to find out)

https://codereview.chromium.org/263703002/diff/1/extensions/common/manifest_h...
extensions/common/manifest_handlers/shared_module_info.h:53: // whitelist is
specified, all extensions can import this extension.
Oh, ok, I guess you say that right here. Maybe just move this second sentence up
into a comment above IsExportAllowedByWhitelist?

[elijahtaylor1, 2014-05-02 00:06:05]

https://codereview.chromium.org/263703002/diff/1/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/263703002/diff/1/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:4562: +        Unable to import extension
with ID "<ph name="IMPORT_ID">$1<ex>aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa</ex></ph>"
because it is not allowed by whitelist.
On 2014/05/01 17:50:15, Antony Sargent wrote:
> nit: "because it is not allowed by whitelist" doesn't quite read right. Maybe
> try something like:
> 
>  because it is not allowed by its whitelist 
> 
> or
> 
>  because it is not allowed by "<ph
> name="IMPORT_ID">$1<ex>aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa</ex></ph>"'s whitelist
> 
> 
> 
>  

Done.

https://codereview.chromium.org/263703002/diff/1/extensions/common/manifest_h...
File extensions/common/manifest_handlers/shared_module_info.h (right):

https://codereview.chromium.org/263703002/diff/1/extensions/common/manifest_h...
extensions/common/manifest_handlers/shared_module_info.h:40: const std::string&
other_id);
On 2014/05/01 17:50:15, Antony Sargent wrote:
> Can you add a comment here mentioning that in the absence of an explicit
> whitelist, that exporting to any extension is allowed? (I wondered whether
that
> was the case when looking at the method signature here, and had to look at the
> implementation to find out)
> 

Done.

https://codereview.chromium.org/263703002/diff/1/extensions/common/manifest_h...
extensions/common/manifest_handlers/shared_module_info.h:53: // whitelist is
specified, all extensions can import this extension.
On 2014/05/01 17:50:15, Antony Sargent wrote:
> Oh, ok, I guess you say that right here. Maybe just move this second sentence
up
> into a comment above IsExportAllowedByWhitelist?

Done.

[elijahtaylor1, 2014-05-02 18:54:37]

The CQ bit was checked by elijahtaylor@chromium.org

[commit-bot: I haz the power, 2014-05-02 18:54:52]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/elijahtaylor@chromium.org/263703002/20001

[commit-bot: I haz the power, 2014-05-02 22:28:07]

Change committed as 267943