chrome/browser/extensions/shared_module_service.cc - Issue 263703002: Allow shared modules to whitelist extensions that import them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/shared_module_service.cc

Issue 263703002: Allow shared modules to whitelist extensions that import them. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: feedback Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/shared_module_service.cc

diff --git a/chrome/browser/extensions/shared_module_service.cc b/chrome/browser/extensions/shared_module_service.cc

index 6deb9bfede6ac8f2e04f8d2822a40f8de95459c6..78e9ab74e21c6c06c95f8661e9c110e776fb5aea 100644

--- a/chrome/browser/extensions/shared_module_service.cc

+++ b/chrome/browser/extensions/shared_module_service.cc

@@ -62,6 +62,9 @@ SharedModuleService::ImportStatus SharedModuleService::CheckImports(

}

} else if (!SharedModuleInfo::IsSharedModule(imported_module)) {

return IMPORT_STATUS_UNRECOVERABLE;

+ } else if (!SharedModuleInfo::IsExportAllowedByWhitelist(imported_module,

+ extension->id())) {

+ return IMPORT_STATUS_UNRECOVERABLE;

} else if (version_required.IsValid() &&

imported_module->version()->CompareTo(version_required) < 0) {

if (imported_module->from_webstore()) {