Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2637003005: Preparsing inner funcs: simplify test-parsing/NoPessimisticContextAllocation. (Closed)

Created:
3 years, 11 months ago by marja
Modified:
3 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Preparsing inner funcs: simplify test-parsing/NoPessimisticContextAllocation. Reduce duplication of the inner function declaration + now we get the test for inner arrow functions for free (if we later implement lazy inner arrow functions). BUG=v8:5501, v8:5516 Review-Url: https://codereview.chromium.org/2637003005 Cr-Commit-Position: refs/heads/master@{#42412} Committed: https://chromium.googlesource.com/v8/v8/+/9e6691fb2f6a3694ae0818dfbd2cec444e94e3af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -281 lines) Patch
M test/cctest/test-parsing.cc View 1 chunk +237 lines, -281 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
Toon Verwaest
lgtm
3 years, 11 months ago (2017-01-17 14:05:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637003005/1
3 years, 11 months ago (2017-01-17 14:18:15 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 14:25:43 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/9e6691fb2f6a3694ae0818dfbd2cec444e9...

Powered by Google App Engine
This is Rietveld 408576698