Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: content/public/common/manifest.h

Issue 2637003002: Add share_target field to Manifest. (Closed)
Patch Set: Documentation update. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/manifest.h
diff --git a/content/public/common/manifest.h b/content/public/common/manifest.h
index d558d66978673f9ce20c4b0284a57818adda63ff..018f3f9a3a09829984e57b5b3c84c5c0b41c1e76 100644
--- a/content/public/common/manifest.h
+++ b/content/public/common/manifest.h
@@ -58,6 +58,18 @@ struct CONTENT_EXPORT Manifest {
std::vector<IconPurpose> purpose;
};
+ // Structure representing how a Web Share target handles an incoming share.
+ struct CONTENT_EXPORT ShareTarget {
+ ShareTarget();
+ ~ShareTarget();
+
+ bool is_null() const;
+
+ // The URL template that contains placeholders to be replaced with shared
+ // data. Null if the parsing failed.
+ base::NullableString16 url_template;
+ };
+
// Structure representing a related application.
struct CONTENT_EXPORT RelatedApplication {
RelatedApplication();
@@ -107,6 +119,9 @@ struct CONTENT_EXPORT Manifest {
// icons inside the JSON array were invalid.
std::vector<Icon> icons;
+ // Null if parsing failed or the field was not present.
Matt Giuca 2017/01/23 00:18:06 Document that this field is non-standard and part
mlamouri (slow - plz ping) 2017/01/23 00:22:26 Could you say that this should not be exposed to w
constantina 2017/01/23 02:51:36 Done.
constantina 2017/01/23 02:51:36 Done.
+ ShareTarget share_target;
mlamouri (slow - plz ping) 2017/01/23 00:22:26 Would it make sense to use base::optional<> here?
constantina 2017/01/23 02:51:36 Yes, it would. Done.
+
// Empty if the parsing failed, the field was not present, empty or all the
// applications inside the array were invalid. The order of the array
// indicates the priority of the application to use.

Powered by Google App Engine
This is Rietveld 408576698