Chromium Code Reviews| Index: content/public/common/manifest.cc |
| diff --git a/content/public/common/manifest.cc b/content/public/common/manifest.cc |
| index 8e09aad2e71ea9aa86f681d7df267f2dbbddb09c..0e249255781e42fd0d30621ea85b3fffa45eb2a3 100644 |
| --- a/content/public/common/manifest.cc |
| +++ b/content/public/common/manifest.cc |
| @@ -14,23 +14,28 @@ const int64_t Manifest::kInvalidOrMissingColor = |
| static_cast<int64_t>(std::numeric_limits<int32_t>::max()) + 1; |
| const size_t Manifest::kMaxIPCStringLength = 4 * 1024; |
| -Manifest::Icon::Icon() { } |
| +Manifest::Icon::Icon() {} |
|
mlamouri (slow - plz ping)
2017/01/23 00:22:26
= default;
constantina
2017/01/23 02:51:36
Done.
|
| Manifest::Icon::Icon(const Icon& other) = default; |
| -Manifest::Icon::~Icon() { |
| -} |
| +Manifest::Icon::~Icon() {} |
|
mlamouri (slow - plz ping)
2017/01/23 00:22:26
ditto... and in many places below
constantina
2017/01/23 02:51:36
Done.
|
| bool Manifest::Icon::operator==(const Manifest::Icon& other) const { |
| return src == other.src && type == other.type && sizes == other.sizes; |
| } |
| -Manifest::RelatedApplication::RelatedApplication() { |
| -} |
| +Manifest::ShareTarget::ShareTarget() {} |
| + |
| +Manifest::ShareTarget::~ShareTarget() {} |
| -Manifest::RelatedApplication::~RelatedApplication() { |
| +bool Manifest::ShareTarget::is_null() const { |
| + return url_template.is_null(); |
| } |
| +Manifest::RelatedApplication::RelatedApplication() {} |
| + |
| +Manifest::RelatedApplication::~RelatedApplication() {} |
| + |
| Manifest::Manifest() |
| : display(blink::WebDisplayModeUndefined), |
| orientation(blink::WebScreenOrientationLockDefault), |
| @@ -41,8 +46,7 @@ Manifest::Manifest() |
| Manifest::Manifest(const Manifest& other) = default; |
| -Manifest::~Manifest() { |
| -} |
| +Manifest::~Manifest() {} |
| bool Manifest::IsEmpty() const { |
| return name.is_null() && |
| @@ -51,6 +55,7 @@ bool Manifest::IsEmpty() const { |
| display == blink::WebDisplayModeUndefined && |
| orientation == blink::WebScreenOrientationLockDefault && |
| icons.empty() && |
| + share_target.is_null() && |
| related_applications.empty() && |
| !prefer_related_applications && |
| theme_color == Manifest::kInvalidOrMissingColor && |