Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: content/renderer/manifest/manifest_parser.h

Issue 2637003002: Add share_target field to Manifest. (Closed)
Patch Set: Doc update and clean up Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/manifest/manifest_parser.h
diff --git a/content/renderer/manifest/manifest_parser.h b/content/renderer/manifest/manifest_parser.h
index 610566b4b8ddfe4ec1b52d93cb894cb11be38af2..c2cbb052d733cac1f95e8e5b9c4e59efa385b865 100644
--- a/content/renderer/manifest/manifest_parser.h
+++ b/content/renderer/manifest/manifest_parser.h
@@ -146,6 +146,20 @@ class CONTENT_EXPORT ManifestParser {
std::vector<Manifest::Icon> ParseIcons(
const base::DictionaryValue& dictionary);
+ // Parses the 'url_template' field of a Share Target, as defined in:
+ // https://github.com/WICG/web-share-target/blob/master/docs/interface.md
constantina 2017/01/18 07:52:18 Documentation doesn't reference dictionary structu
+ // Returns the parsed string if any, or a null string if the field was not
+ // present, or didn't contain a string.
+ base::NullableString16 ParseShareTargetURLTemplate(
nasko 2017/01/18 23:39:13 nit: Acronyms (such as URL) need to only upper cas
constantina 2017/01/19 00:07:32 Capitalised every letter for consistency with the
+ const base::DictionaryValue& share_target);
+
+ // Parses the 'share_target' field of a Manifest, as defined in:
+ // https://github.com/WICG/web-share-target/blob/master/docs/interface.md
+ // Returns the parsed Share Target. The returned Share Target is null if
nasko 2017/01/18 23:39:13 nit: "target" as commented in another file with si
constantina 2017/01/19 00:07:32 Done.
+ // the field didn't exist, parsing failed, or it was empty.
+ Manifest::ShareTarget ParseShareTarget(
+ const base::DictionaryValue& dictionary);
+
// Parses the 'platform' field of a related application, as defined in:
// https://w3c.github.io/manifest/#dfn-steps-for-processing-the-platform-member-of-an-application
// Returns the parsed string if any, a null string if the parsing failed.

Powered by Google App Engine
This is Rietveld 408576698