Add share_target field to Manifest.

content/renderer/manifest/manifest_parser.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_MANIFEST_MANIFEST_PARSER_H_
 #define CONTENT_RENDERER_MANIFEST_MANIFEST_PARSER_H_
 
 #include <stdint.h>
 
 #include <memory>
@@ skipping 128 matching lines @@
   std::vector<Manifest::Icon::IconPurpose> ParseIconPurpose(
       const base::DictionaryValue& icon);
 
   // Parses the 'icons' field of a Manifest, as defined in:
   // https://w3c.github.io/manifest/#dfn-steps-for-processing-an-array-of-images
   // Returns a vector of Manifest::Icon with the successfully parsed icons, if
   // any. An empty vector if the field was not present or empty.
   std::vector<Manifest::Icon> ParseIcons(
       const base::DictionaryValue& dictionary);
 
+  // Parses the 'url_template' field of a Share Target, as defined in:
+  // https://github.com/WICG/web-share-target/blob/master/docs/interface.md

[constantina, 2017/01/18 07:52:18]

Documentation doesn't reference dictionary structure for the field; pull request
to update it in progress.

+  // Returns the parsed string if any, or a null string if the field was not
+  // present, or didn't contain a string.
+  base::NullableString16 ParseShareTargetURLTemplate(

[nasko, 2017/01/18 23:39:13]

nit: Acronyms (such as URL) need to only upper case the first letter -
ParseShareTargetUrlTemplate.

[constantina, 2017/01/19 00:07:32]

Capitalised every letter for consistency with the rest of the file.

+      const base::DictionaryValue& share_target);
+
+  // Parses the 'share_target' field of a Manifest, as defined in:
+  // https://github.com/WICG/web-share-target/blob/master/docs/interface.md
+  // Returns the parsed Share Target. The returned Share Target is null if

[nasko, 2017/01/18 23:39:13]

nit: "target" as commented in another file with similar text.

[constantina, 2017/01/19 00:07:32]

Done.

+  // the field didn't exist, parsing failed, or it was empty.
+  Manifest::ShareTarget ParseShareTarget(
+      const base::DictionaryValue& dictionary);
+
   // Parses the 'platform' field of a related application, as defined in:
   // https://w3c.github.io/manifest/#dfn-steps-for-processing-the-platform-member-of-an-application
   // Returns the parsed string if any, a null string if the parsing failed.
   base::NullableString16 ParseRelatedApplicationPlatform(
       const base::DictionaryValue& application);
 
   // Parses the 'url' field of a related application, as defined in:
   // https://w3c.github.io/manifest/#dfn-steps-for-processing-the-url-member-of-an-application
   // Returns the paresed GURL if any, an empty GURL if the parsing failed.
   GURL ParseRelatedApplicationURL(const base::DictionaryValue& application);
@@ skipping 48 matching lines @@
   bool failed_;
   Manifest manifest_;
   std::vector<ManifestDebugInfo::Error> errors_;
 
   DISALLOW_COPY_AND_ASSIGN(ManifestParser);
 };
 
 } // namespace content
 
 #endif  // CONTENT_RENDERER_MANIFEST_MANIFEST_PARSER_H_