Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 2636993002: swarming: Fix named cache support. (Closed)

Created:
3 years, 11 months ago by M-A Ruel
Modified:
3 years, 11 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org, nodir, estaab
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

swarming: Fix named cache support. - Add support for named cache in swarming.py so it can be used via the CLI. - Reshuffled the swarming.py trigger option grouping to differentiate between properties and request metadata. - Add integration smoke test to ensure it actually work. - Fix named cache bug, it didn't work: free_space wasn't initialized so all the named caches were deleted after use if min_free_space wasn't None. - made min_free_space == 0 use the normal path. - Add logging to help diagnose problems. R=vadimsh@chromium.org BUG=667290 Review-Url: https://codereview.chromium.org/2636993002 Committed: https://github.com/luci/luci-py/commit/83e5bed8895f64f184dd994d721420835c9cbb64

Patch Set 1 : . #

Patch Set 2 : Fix swarming_test.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -48 lines) Patch
M appengine/swarming/local_smoke_test.py View 1 chunk +68 lines, -0 lines 0 comments Download
M appengine/swarming/tools/start_bot.py View 2 chunks +8 lines, -6 lines 0 comments Download
M client/named_cache.py View 7 chunks +16 lines, -5 lines 0 comments Download
M client/swarming.py View 5 chunks +49 lines, -37 lines 0 comments Download
M client/tests/swarming_test.py View 1 7 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
M-A Ruel
3 years, 11 months ago (2017-01-16 22:16:15 UTC) #6
Vadim Sh.
lgtm
3 years, 11 months ago (2017-01-17 23:20:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636993002/20001
3 years, 11 months ago (2017-01-17 23:26:08 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Luci-py Presubmit on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/33c7ae60edeb5010)
3 years, 11 months ago (2017-01-18 00:01:05 UTC) #12
M-A Ruel
On 2017/01/18 00:01:05, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 11 months ago (2017-01-18 00:51:12 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636993002/40001
3 years, 11 months ago (2017-01-18 00:51:28 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 00:56:09 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://github.com/luci/luci-py/commit/83e5bed8895f64f184dd994d721420835c9cbb64

Powered by Google App Engine
This is Rietveld 408576698