Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 2636973002: Adding test to verify that Canvas2DLayerBridge flushes only when required (Closed)

Created:
3 years, 11 months ago by Justin Novosad
Modified:
3 years, 11 months ago
Reviewers:
xlai (Olivia)
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, ajuma+watch-canvas_chromium.org, Stephen Chennney, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, blink-reviews-platform-graphics_chromium.org, Rik, f(malita), blink-reviews, kinuko+watch, ajuma+watch_chromium.org, danakj+watch_chromium.org, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding test to verify that Canvas2DLayerBridge flushes only when required This is a follow-up to CL: https://codereview.chromium.org/2637553002/ It adds a unit test to validate the functionality of the new optimization that prevents redundant flushing. BUG=681200 Review-Url: https://codereview.chromium.org/2636973002 Cr-Commit-Position: refs/heads/master@{#443955} Committed: https://chromium.googlesource.com/chromium/src/+/a4eab9aa9b5cbeb5e9dde2ce1eb0ecd6313c8f6c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp View 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Justin Novosad
PTAL
3 years, 11 months ago (2017-01-16 20:40:22 UTC) #4
xlai (Olivia)
lgtm
3 years, 11 months ago (2017-01-16 21:52:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636973002/1
3 years, 11 months ago (2017-01-16 22:23:11 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 22:29:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a4eab9aa9b5cbeb5e9dde2ce1eb0...

Powered by Google App Engine
This is Rietveld 408576698