Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 2636963003: Revert of [EditCommandSource] Rename and move |EditorCommandSource| to "CompositeEditCommand.h (1/3) (Closed)

Created:
3 years, 11 months ago by chongz
Modified:
3 years, 11 months ago
Reviewers:
tkent, Xiaocheng
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, Yuta Kitamura
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [EditCommandSource] Rename and move |EditorCommandSource| to "CompositeEditCommand.h" (1/3) (patchset #2 id:40001 of https://codereview.chromium.org/2578753002/ ) Reason for revert: We want to revert all CLs and start over the refactor process, see: https://crbug.com/673789. Original issue's description: > [EditCommandSource] Rename and move |EditorCommandSource| to "CompositeEditCommand.h" (1/3) > > This is the sub-patch (1/3) of supporting |EditCommandSource| in > |CompositeEditCommand| (https://crrev.com/2574793002). > > This CL: > 1. Renamed |EditorCommandSource| => |EditCommandSource| > 2. Changed type |enum| => |enum class| > 3. Moved from "Editor.h" => "CompositeEditCommand.h" > > This CL shouldn't have any behavior change. > > BUG=673789 > > Committed: https://crrev.com/17c7368db5e14c05733b204bbf79e73998810d4b > Cr-Commit-Position: refs/heads/master@{#438979} TBR=tkent@chromium.org,xiaochengh@chromium.org,yosin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=673789 Review-Url: https://codereview.chromium.org/2636963003 Cr-Commit-Position: refs/heads/master@{#444417} Committed: https://chromium.googlesource.com/chromium/src/+/5b45dc22297adb1eba7518c2731ec1de87513e99

Patch Set 1 #

Patch Set 2 : Fix conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -195 lines) Patch
M third_party/WebKit/Source/core/editing/Editor.h View 1 4 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/DocumentExecCommand.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 1 147 chunks +179 lines, -177 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
chongz
Created Revert of [EditCommandSource] Rename and move |EditorCommandSource| to "CompositeEditCommand.h" (1/3)
3 years, 11 months ago (2017-01-17 18:03:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636963003/1
3 years, 11 months ago (2017-01-17 18:04:17 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/136944) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 11 months ago (2017-01-17 18:05:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636963003/160001
3 years, 11 months ago (2017-01-18 15:53:06 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 18:01:37 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/5b45dc22297adb1eba7518c2731e...

Powered by Google App Engine
This is Rietveld 408576698