Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1274)

Issue 2636953002: cc: Compute RenderSurfaceImpl's ClipTreeIndex using its effect node (Closed)

Created:
3 years, 11 months ago by ajuma
Modified:
3 years, 11 months ago
Reviewers:
jaydasika, weiliangc
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Compute RenderSurfaceImpl's ClipTreeIndex using its effect node This makes RenderSurfaceImpl::ClipTreeIndex use the surface's effect node rather than its owning layer to find its clip id. The clip id on an effect node is actually for the parent of the owning layer's clip node, but the parent clip node is in fact the one that call sites care about since it represents the clip applied to the surface's output rather than to its input. BUG=679837 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2636953002 Cr-Commit-Position: refs/heads/master@{#443935} Committed: https://chromium.googlesource.com/chromium/src/+/ed86f4eb6b5a10332b8d4477afc19834faa6079a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M cc/layers/render_surface_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/draw_property_utils.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
ajuma
3 years, 11 months ago (2017-01-16 19:08:30 UTC) #6
weiliangc
LGTM
3 years, 11 months ago (2017-01-16 19:49:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636953002/1
3 years, 11 months ago (2017-01-16 19:50:43 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 19:55:03 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ed86f4eb6b5a10332b8d4477afc1...

Powered by Google App Engine
This is Rietveld 408576698