[regexp] Implement regexp groups as wrapper.

[regexp] Implement regexp groups as wrapper.

Non-capturing groups so far did not have any effect, so we elided
them in the regexp parser. However, they do affect how lookarounds
are parsed: in unicode mode, lookarounds are not quantifiable. They
are however if wrapped in a group.

BUG=v8:5845
Review-Url: https://codereview.chromium.org/2636883002
Cr-Commit-Position: refs/heads/master@{#42436}
Committed: https://chromium.googlesource.com/v8/v8/+/92acec568c83c6278ce2e31493c7a1cd1dd6c8c5

[Yang, 2017-01-16 10:34:31]

yangguo@chromium.org changed reviewers:
+ jgruber@chromium.org

[Yang, 2017-01-16 10:56:38]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 10:56:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[erikcorry, 2017-01-16 11:34:31]

erikcorry@google.com changed reviewers:
+ erikcorry@google.com

[erikcorry, 2017-01-16 11:34:32]

lgtm

Fast work :-)

https://codereview.chromium.org/2636883002/diff/20001/src/regexp/regexp-ast.cc
File src/regexp/regexp-ast.cc (right):

https://codereview.chromium.org/2636883002/diff/20001/src/regexp/regexp-ast.c...
src/regexp/regexp-ast.cc:268: os_ << "( ";
Should probably be "(?:"

[jgruber, 2017-01-16 11:35:40]

lgtm

https://codereview.chromium.org/2636883002/diff/20001/src/regexp/regexp-ast.cc
File src/regexp/regexp-ast.cc (right):

https://codereview.chromium.org/2636883002/diff/20001/src/regexp/regexp-ast.c...
src/regexp/regexp-ast.cc:268: os_ << "( ";
Nit: Seems like the convention is to use a char after the opening paren for
disambiguation.

[commit-bot: I haz the power, 2017-01-16 11:36:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 11:36:35]

Dry run: This issue passed the CQ dry run.

[Yang, 2017-01-17 14:41:03]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-01-17 14:41:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
erikcorry@google.com, jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2636883002/#ps40001
(title: "address comments")

[commit-bot: I haz the power, 2017-01-17 14:41:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 14:56:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 14:56:22]

Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[Yang, 2017-01-18 07:48:53]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-01-18 07:48:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
erikcorry@google.com, jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2636883002/#ps60001
(title: "fix")

[commit-bot: I haz the power, 2017-01-18 07:49:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 08:15:01]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484725733244360,
"parent_rev": "2851866cfec55352f1dd79345137a3d575693e80", "commit_rev":
"92acec568c83c6278ce2e31493c7a1cd1dd6c8c5"}

[commit-bot: I haz the power, 2017-01-18 08:15:05]

Description was changed from

==========
[regexp] Implement regexp groups as wrapper.

Non-capturing groups so far did not have any effect, so we elided
them in the regexp parser. However, they do affect how lookarounds
are parsed: in unicode mode, lookarounds are not quantifiable. They
are however if wrapped in a group.

BUG=v8:5845
==========

to

==========
[regexp] Implement regexp groups as wrapper.

Non-capturing groups so far did not have any effect, so we elided
them in the regexp parser. However, they do affect how lookarounds
are parsed: in unicode mode, lookarounds are not quantifiable. They
are however if wrapped in a group.

BUG=v8:5845

Review-Url: https://codereview.chromium.org/2636883002
Cr-Commit-Position: refs/heads/master@{#42436}
Committed:
https://chromium.googlesource.com/v8/v8/+/92acec568c83c6278ce2e31493c7a1cd1dd...
==========

[commit-bot: I haz the power, 2017-01-18 08:15:06]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/92acec568c83c6278ce2e31493c7a1cd1dd...