Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

Issue 2636833003: Support "display": "fullscreen" for sites added to the home screen. (Closed)
Patch Set: Fix incorrect indentation. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
index 7a35c67a8ce7a90cbdfc875aec890b77f31d55d4..4cb6ef51634a089c540711cd134431b8f1da50ca 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
@@ -119,8 +119,11 @@ public class WebappActivity extends FullScreenActivity {
getActivityTab().addObserver(createTabObserver());
getActivityTab().getTabWebContentsDelegateAndroid().setDisplayMode(
WebDisplayMode.Standalone);
dominickn 2017/01/16 22:49:01 Nit: this should be: getActivityTab().getTabWebCo
Leo 2017/01/18 05:09:40 Thanks for the tips. So what will happen if the di
dominickn 2017/01/18 05:56:17 Currently, minimal-ui does not open a WebappActivi
Leo 2017/01/18 23:03:12 Thanks for the explanation. Good to know that.
- // TODO(dominickn): send the web app into fullscreen if mDisplayMode is
- // WebDisplayMode.Fullscreen. See crbug.com/581522
+ if (mWebappInfo.displayMode() == WebDisplayMode.Fullscreen) {
+ enterImmersiveMode(getWindow().getDecorView());
+ getActivityTab().getTabWebContentsDelegateAndroid().setDisplayMode(
+ WebDisplayMode.Fullscreen);
+ }
}
@Override

Powered by Google App Engine
This is Rietveld 408576698