Support "display": "fullscreen" for sites added to the home screen.

chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.webapps;
 
 import android.content.Intent;
 import android.graphics.Bitmap;
 import android.graphics.Color;
 import android.graphics.drawable.Drawable;
@@ skipping 75 matching lines @@
 
         WebappInfo newWebappInfo = createWebappInfo(intent);
         if (newWebappInfo == null) {
             Log.e(TAG, "Failed to parse new Intent: " + intent);
             finish();
         } else if (!TextUtils.equals(mWebappInfo.id(), newWebappInfo.id())) {
             mWebappInfo = newWebappInfo;
             resetSavedInstanceState();
             if (mIsInitialized) initializeUI(null);
             // TODO(dominickn): send the web app into fullscreen if mDisplayMode is
             // WebDisplayMode.Fullscreen. See crbug.com/581522

[dominickn, 2017/01/16 22:49:01]

Nit: remove this TODO.

[Leo, 2017/01/18 23:03:12]

Acknowledged.

         }
     }
 
     protected boolean isInitialized() {
         return mIsInitialized;
     }
 
     protected WebappInfo createWebappInfo(Intent intent) {
         return (intent == null) ? WebappInfo.createEmpty() : WebappInfo.create(intent);
     }
 
     private void initializeUI(Bundle savedInstanceState) {
         // We do not load URL when restoring from saved instance states.
         if (savedInstanceState == null && mWebappInfo.isInitialized()) {
             if (TextUtils.isEmpty(getActivityTab().getUrl())) {
                 getActivityTab().loadUrl(new LoadUrlParams(
                         mWebappInfo.uri().toString(), PageTransition.AUTO_TOPLEVEL));
             }
         } else {
             if (NetworkChangeNotifier.isOnline()) getActivityTab().reloadIgnoringCache();
         }
 
         getActivityTab().addObserver(createTabObserver());
         getActivityTab().getTabWebContentsDelegateAndroid().setDisplayMode(
                 WebDisplayMode.Standalone);

[dominickn, 2017/01/16 22:49:01]

Nit: this should be:

getActivityTab().getTabWebContentsDelegateAndroid().setDisplayMode(
        mWebappInfo.displayMode());

[Leo, 2017/01/18 05:09:40]

Thanks for the tips. So what will happen if the display mode was MinimalUi?
Is there any logic to fallback to standalone safely?

[dominickn, 2017/01/18 05:56:17]

Currently, minimal-ui does not open a WebappActivity (it just opens an ordinary
browser tab), so we don't need to worry about a fallback. When we move to
implementing minimal-ui, we'll add the appropriate logic in here. :)

[Leo, 2017/01/18 23:03:12]

Thanks for the explanation. Good to know that.

-        // TODO(dominickn): send the web app into fullscreen if mDisplayMode is
-        // WebDisplayMode.Fullscreen. See crbug.com/581522
+        if (mWebappInfo.displayMode() == WebDisplayMode.Fullscreen) {
+            enterImmersiveMode(getWindow().getDecorView());
+            getActivityTab().getTabWebContentsDelegateAndroid().setDisplayMode(
+                    WebDisplayMode.Fullscreen);
+        }
     }
 
     @Override
     public void preInflationStartup() {
         WebappInfo info = createWebappInfo(getIntent());
 
         String id = "";
         if (info != null) {
             mWebappInfo = info;
             id = info.id();
@@ skipping 449 matching lines @@
         return new WebappDelegateFactory(this);
     }
 
     // We're temporarily disable CS on webapp since there are some issues. (http://crbug.com/471950)
     // TODO(changwan): re-enable it once the issues are resolved.
     @Override
     protected boolean isContextualSearchAllowed() {
         return false;
     }
 }