[build/android] Update adb_command_line.py to use flag_changer

[build/android] Update adb_command_line.py to use flag_changer

Now flag_changer is the main module intended to be used for managing
command line flags passed to Chrome.

API changes:
- added --name option to specify command line file name
- both --device-path and --executable are now deprecated

Depends on CL: https://codereview.chromium.org/2633133002/

BUG=catapult:#3112

Review-Url: https://codereview.chromium.org/2636553002
Cr-Commit-Position: refs/heads/master@{#445010}
Committed: https://chromium.googlesource.com/chromium/src/+/9f5c346350c3ac389de94de2ae5b4441205186da

[perezju, 2017-01-13 17:39:04]

perezju@chromium.org changed reviewers:
+ jbudorick@chromium.org

[perezju, 2017-01-13 17:39:05]

Depends on a (yet unwritten) CL to add flag_changer.GetCurrentFlags(), but this
is the main gist.

[jbudorick, 2017-01-13 20:50:00]

https://codereview.chromium.org/2636553002/diff/1/build/android/adb_command_l...
File build/android/adb_command_line.py (left):

https://codereview.chromium.org/2636553002/diff/1/build/android/adb_command_l...
build/android/adb_command_line.py:83: return 0
nit: this should still return 0

https://codereview.chromium.org/2636553002/diff/1/build/android/adb_command_l...
File build/android/adb_command_line.py (right):

https://codereview.chromium.org/2636553002/diff/1/build/android/adb_command_l...
build/android/adb_command_line.py:31: parser.add_argument('--filename',
default='chrome-command-line',
Why'd you make this a default as opposed to having it encoded in the wrapped
scripts?

https://codereview.chromium.org/2636553002/diff/1/build/android/adb_command_l...
build/android/adb_command_line.py:74: for d, desc, flags in updated_values:
Nice!

[perezju, 2017-01-16 14:48:05]

Description was changed from

==========
[build/android] Update adb_command_line.py to use flag_changer

Now flag_changer is main module intended to be used for managing
command line flags passed to Chrome.

API changes:
- added --filename option that defaults to 'chrome-command-line'
- both --device-path and --executable are now deprecated

BUG=catapult:#3112
==========

to

==========
[build/android] Update adb_command_line.py to use flag_changer

Now flag_changer is the main module intended to be used for managing
command line flags passed to Chrome.

API changes:
- added --name option to specify command line file name
- both --device-path and --executable are now deprecated

Depends on CL: https://codereview.chromium.org/2633133002/

BUG=catapult:#3112
==========

[perezju, 2017-01-16 14:48:20]

https://codereview.chromium.org/2636553002/diff/1/build/android/adb_command_l...
File build/android/adb_command_line.py (left):

https://codereview.chromium.org/2636553002/diff/1/build/android/adb_command_l...
build/android/adb_command_line.py:83: return 0
On 2017/01/13 20:50:00, jbudorick wrote:
> nit: this should still return 0

Done.

https://codereview.chromium.org/2636553002/diff/1/build/android/adb_command_l...
File build/android/adb_command_line.py (right):

https://codereview.chromium.org/2636553002/diff/1/build/android/adb_command_l...
build/android/adb_command_line.py:31: parser.add_argument('--filename',
default='chrome-command-line',
On 2017/01/13 20:50:00, jbudorick wrote:
> Why'd you make this a default as opposed to having it encoded in the wrapped
> scripts?

Ok. Changed. Also found more wrapping scripts that needed updating.

Btw, is this python script used in other places (e.g. recipes?) that should also
be changed?

[jbudorick, 2017-01-17 18:08:33]

On 2017/01/16 14:48:20, perezju wrote:
>
https://codereview.chromium.org/2636553002/diff/1/build/android/adb_command_l...
> File build/android/adb_command_line.py (left):
> 
>
https://codereview.chromium.org/2636553002/diff/1/build/android/adb_command_l...
> build/android/adb_command_line.py:83: return 0
> On 2017/01/13 20:50:00, jbudorick wrote:
> > nit: this should still return 0
> 
> Done.
> 
>
https://codereview.chromium.org/2636553002/diff/1/build/android/adb_command_l...
> File build/android/adb_command_line.py (right):
> 
>
https://codereview.chromium.org/2636553002/diff/1/build/android/adb_command_l...
> build/android/adb_command_line.py:31: parser.add_argument('--filename',
> default='chrome-command-line',
> On 2017/01/13 20:50:00, jbudorick wrote:
> > Why'd you make this a default as opposed to having it encoded in the wrapped
> > scripts?
> 
> Ok. Changed. Also found more wrapping scripts that needed updating.
> 
> Btw, is this python script used in other places (e.g. recipes?) that should
also
> be changed?

I think it's just this one:
https://codesearch.chromium.org/chromium/build/scripts/slave/recipe_modules/c...

[perezju, 2017-01-18 10:58:56]

On 2017/01/17 18:08:33, jbudorick wrote:
> I think it's just this one:
>
https://codesearch.chromium.org/chromium/build/scripts/slave/recipe_modules/c...

Sounds good. If you are happy with the change, and since it's backwards
compatible, it can be landed now.

I'll also prepare another CL to fix/upgrade that client.

[jbudorick, 2017-01-18 14:04:07]

On 2017/01/18 10:58:56, perezju wrote:
> On 2017/01/17 18:08:33, jbudorick wrote:
> > I think it's just this one:
> >
>
https://codesearch.chromium.org/chromium/build/scripts/slave/recipe_modules/c...
> 
> Sounds good. If you are happy with the change, and since it's backwards
> compatible, it can be landed now.
> 
> I'll also prepare another CL to fix/upgrade that client.

sgtm + lgtm

[perezju, 2017-01-18 14:15:21]

The CQ bit was checked by perezju@chromium.org

[commit-bot: I haz the power, 2017-01-18 14:15:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 14:22:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 14:22:35]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[perezju, 2017-01-18 14:26:22]

On 2017/01/18 14:22:35, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Ahh.. silly me, the CL this depends on hasn't landed yet:
https://codereview.chromium.org/2633133002/

[jbudorick, 2017-01-18 14:28:18]

On 2017/01/18 14:26:22, perezju wrote:
> On 2017/01/18 14:22:35, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> 
> Ahh.. silly me, the CL this depends on hasn't landed yet:
> https://codereview.chromium.org/2633133002/

Reviewing that one now.

[perezju, 2017-01-19 09:25:39]

The CQ bit was checked by perezju@chromium.org

[commit-bot: I haz the power, 2017-01-19 09:25:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 09:31:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 09:31:11]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[perezju, 2017-01-19 11:46:52]

The CQ bit was checked by perezju@chromium.org

[perezju, 2017-01-19 11:46:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
jbudorick@chromium.org
Link to the patchset: https://codereview.chromium.org/2636553002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-19 11:47:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 11:53:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 11:53:16]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[perezju, 2017-01-19 12:21:09]

On 2017/01/19 11:53:16, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

The CL this depends on has landed but not rolled into chromium yet :(
https://github.com/catapult-project/catapult/issues/3149

[perezju, 2017-01-20 07:09:32]

The CQ bit was checked by perezju@chromium.org

[commit-bot: I haz the power, 2017-01-20 07:09:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 07:42:33]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484896172861990,
"parent_rev": "fd1eee2323b24d2203d431246177096de15a3308", "commit_rev":
"9f5c346350c3ac389de94de2ae5b4441205186da"}

[commit-bot: I haz the power, 2017-01-20 07:43:09]

Description was changed from

==========
[build/android] Update adb_command_line.py to use flag_changer

Now flag_changer is the main module intended to be used for managing
command line flags passed to Chrome.

API changes:
- added --name option to specify command line file name
- both --device-path and --executable are now deprecated

Depends on CL: https://codereview.chromium.org/2633133002/

BUG=catapult:#3112
==========

to

==========
[build/android] Update adb_command_line.py to use flag_changer

Now flag_changer is the main module intended to be used for managing
command line flags passed to Chrome.

API changes:
- added --name option to specify command line file name
- both --device-path and --executable are now deprecated

Depends on CL: https://codereview.chromium.org/2633133002/

BUG=catapult:#3112

Review-Url: https://codereview.chromium.org/2636553002
Cr-Commit-Position: refs/heads/master@{#445010}
Committed:
https://chromium.googlesource.com/chromium/src/+/9f5c346350c3ac389de94de2ae5b...
==========

[commit-bot: I haz the power, 2017-01-20 07:43:10]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9f5c346350c3ac389de94de2ae5b...