Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2636543002: PreParser scope analysis: sloppy block funcs. (Closed)

Created:
3 years, 11 months ago by marja
Modified:
3 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PreParser scope analysis: sloppy block funcs. - Generalize the sloppy block function data structures to allow PreParser adding and hoisting sloppy block funcs. - This completes PreParser scope analysis. BUG=v8:5501, v8:5516 R=verwaest@chromium.org Review-Url: https://codereview.chromium.org/2636543002 Cr-Commit-Position: refs/heads/master@{#42368} Committed: https://chromium.googlesource.com/v8/v8/+/bbcb33c773d46eebe65e36c1ef4ed5e5b9196fce

Patch Set 1 #

Patch Set 2 : proactive code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -79 lines) Patch
M src/ast/ast.h View 2 chunks +5 lines, -12 lines 0 comments Download
M src/ast/scopes.h View 4 chunks +22 lines, -7 lines 0 comments Download
M src/ast/scopes.cc View 1 11 chunks +65 lines, -31 lines 0 comments Download
M src/parsing/parser.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/parsing/parser.cc View 2 chunks +8 lines, -18 lines 0 comments Download
M src/parsing/parser-base.h View 1 chunk +17 lines, -2 lines 0 comments Download
M src/parsing/preparser.h View 4 chunks +21 lines, -4 lines 0 comments Download
M src/parsing/preparser.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +26 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
marja
ptal
3 years, 11 months ago (2017-01-13 14:38:16 UTC) #3
Toon Verwaest
lgtm
3 years, 11 months ago (2017-01-16 11:40:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636543002/20001
3 years, 11 months ago (2017-01-16 11:41:34 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 12:08:02 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/bbcb33c773d46eebe65e36c1ef4ed5e5b91...

Powered by Google App Engine
This is Rietveld 408576698