Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2636533003: Add chrome://flags entry to enable the standalone content suggestions UI. (Closed)

Created:
3 years, 11 months ago by Bernhard Bauer
Modified:
3 years, 11 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add chrome://flags entry to enable the standalone content suggestions UI. BUG=681869 Review-Url: https://codereview.chromium.org/2636533003 Cr-Commit-Position: refs/heads/master@{#444193} Committed: https://chromium.googlesource.com/chromium/src/+/8c6639a24a1df1f7e78ab630419e41048778b785

Patch Set 1 #

Patch Set 2 : add histogram #

Total comments: 2

Patch Set 3 : update description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (20 generated)
Bernhard Bauer
Please review!
3 years, 11 months ago (2017-01-13 17:42:00 UTC) #4
Bernhard Bauer
On 2017/01/13 17:42:00, Bernhard Bauer wrote: > Please review! Ping :)
3 years, 11 months ago (2017-01-17 13:56:54 UTC) #11
Michael van Ouwerkerk
lgtm with the one comment addressed https://codereview.chromium.org/2636533003/diff/20001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2636533003/diff/20001/chrome/app/generated_resources.grd#newcode15178 chrome/app/generated_resources.grd:15178: + <message name="IDS_FLAGS_ENABLE_NTP_STANDALONE_SUGGESTIONS_UI_DESCRIPTION" ...
3 years, 11 months ago (2017-01-17 15:52:08 UTC) #13
Bernhard Bauer
Alexei, could I get an OWNERS review for the histograms.xml change? Thanks! https://codereview.chromium.org/2636533003/diff/20001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd ...
3 years, 11 months ago (2017-01-17 16:04:42 UTC) #15
dgn
Sorry for the delay, lgtm
3 years, 11 months ago (2017-01-17 16:17:24 UTC) #18
Alexei Svitkine (slow)
lgtm maybe set BUG= on the CL description?
3 years, 11 months ago (2017-01-17 16:40:05 UTC) #19
Bernhard Bauer
On 2017/01/17 16:40:05, Alexei Svitkine (slow) wrote: > lgtm > > maybe set BUG= on ...
3 years, 11 months ago (2017-01-17 17:08:34 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636533003/40001
3 years, 11 months ago (2017-01-17 23:40:48 UTC) #26
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 23:50:54 UTC) #29
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8c6639a24a1df1f7e78ab630419e...

Powered by Google App Engine
This is Rietveld 408576698