|
|
Chromium Code Reviews|
Created:
3 years, 11 months ago by Bernhard Bauer Modified:
3 years, 11 months ago CC:
chromium-reviews, asvitkine+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd chrome://flags entry to enable the standalone content suggestions UI.
BUG=681869
Review-Url: https://codereview.chromium.org/2636533003
Cr-Commit-Position: refs/heads/master@{#444193}
Committed: https://chromium.googlesource.com/chromium/src/+/8c6639a24a1df1f7e78ab630419e41048778b785
Patch Set 1 #Patch Set 2 : add histogram #
Total comments: 2
Patch Set 3 : update description #
Messages
Total messages: 29 (20 generated)
The CQ bit was checked by bauerb@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
bauerb@chromium.org changed reviewers: + dgn@chromium.org
Please review!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by bauerb@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/01/13 17:42:00, Bernhard Bauer wrote: > Please review! Ping :)
mvanouwerkerk@chromium.org changed reviewers: + mvanouwerkerk@chromium.org
lgtm with the one comment addressed https://codereview.chromium.org/2636533003/diff/20001/chrome/app/generated_re... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2636533003/diff/20001/chrome/app/generated_re... chrome/app/generated_resources.grd:15178: + <message name="IDS_FLAGS_ENABLE_NTP_STANDALONE_SUGGESTIONS_UI_DESCRIPTION" desc="Description for the flag to enable foreign sessions suggestions on the New Tab page." translateable="false"> Please update the desc attribute value.
bauerb@chromium.org changed reviewers: + asvitkine@chromium.org
Alexei, could I get an OWNERS review for the histograms.xml change? Thanks! https://codereview.chromium.org/2636533003/diff/20001/chrome/app/generated_re... File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2636533003/diff/20001/chrome/app/generated_re... chrome/app/generated_resources.grd:15178: + <message name="IDS_FLAGS_ENABLE_NTP_STANDALONE_SUGGESTIONS_UI_DESCRIPTION" desc="Description for the flag to enable foreign sessions suggestions on the New Tab page." translateable="false"> On 2017/01/17 15:52:08, Michael van Ouwerkerk wrote: > Please update the desc attribute value. Oops 😅 Done.
The CQ bit was checked by bauerb@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Sorry for the delay, lgtm
lgtm maybe set BUG= on the CL description?
Description was changed from ========== Add chrome://flags entry to enable the standalone content suggestions UI. ========== to ========== Add chrome://flags entry to enable the standalone content suggestions UI. BUG=681869 ==========
On 2017/01/17 16:40:05, Alexei Svitkine (slow) wrote: > lgtm > > maybe set BUG= on the CL description? Done!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bauerb@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mvanouwerkerk@chromium.org Link to the patchset: https://codereview.chromium.org/2636533003/#ps40001 (title: "update description")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484696403536690,
"parent_rev": "f1ac06905684c9b963d358d9c778d58df20719f3", "commit_rev":
"8c6639a24a1df1f7e78ab630419e41048778b785"}
Message was sent while issue was closed.
Description was changed from ========== Add chrome://flags entry to enable the standalone content suggestions UI. BUG=681869 ========== to ========== Add chrome://flags entry to enable the standalone content suggestions UI. BUG=681869 Review-Url: https://codereview.chromium.org/2636533003 Cr-Commit-Position: refs/heads/master@{#444193} Committed: https://chromium.googlesource.com/chromium/src/+/8c6639a24a1df1f7e78ab630419e... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/8c6639a24a1df1f7e78ab630419e... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
