Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2636503003: minor name updates based on spec update at: https://wicg.github.io/longtasks (Closed)

Created:
3 years, 11 months ago by panicker
Modified:
3 years, 11 months ago
Reviewers:
skobes, tdresser
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

minor name updates based on spec update at: https://wicg.github.io/longtasks BUG=681252, 681253 Review-Url: https://codereview.chromium.org/2636503003 Cr-Commit-Position: refs/heads/master@{#444982} Committed: https://chromium.googlesource.com/chromium/src/+/ac7bf105a4b432d23c18f0e4a042b960c2a9af87

Patch Set 1 #

Patch Set 2 : tweaks based on spec updates #

Patch Set 3 : update global-interface layout test expectation #

Messages

Total messages: 23 (14 generated)
panicker
PTAL
3 years, 11 months ago (2017-01-15 01:00:46 UTC) #3
tdresser
LGTM
3 years, 11 months ago (2017-01-16 14:40:44 UTC) #4
skobes
lgtm
3 years, 11 months ago (2017-01-17 18:27:47 UTC) #5
panicker
PTAL I updated tests, and couple more tweaks based on resolving this spec issue: https://github.com/WICG/longtasks/issues/13
3 years, 11 months ago (2017-01-20 00:42:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636503003/20001
3 years, 11 months ago (2017-01-20 01:01:27 UTC) #14
skobes
lgtm
3 years, 11 months ago (2017-01-20 01:14:17 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/372611)
3 years, 11 months ago (2017-01-20 02:33:33 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636503003/20002
3 years, 11 months ago (2017-01-20 02:56:08 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 04:31:25 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:20002) as
https://chromium.googlesource.com/chromium/src/+/ac7bf105a4b432d23c18f0e4a042...

Powered by Google App Engine
This is Rietveld 408576698