Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2636493002: [turbofan] Disable inline allocation of closures. (Closed)

Created:
3 years, 11 months ago by Michael Starzinger
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Disable inline allocation of closures. This puts lowering of {JSCreateClosure} operations behind a flag. For now the benefit of inline allocating such closures is negligible, it does increase code size, and breaks in combination with inlining based on {SharedFunctionInfo}. R=jarin@chromium.org BUG=v8:2206 Review-Url: https://codereview.chromium.org/2636493002 Cr-Commit-Position: refs/heads/master@{#42331} Committed: https://chromium.googlesource.com/v8/v8/+/83f19e7d972c9564b523da49782eb41b0939d8ce

Patch Set 1 #

Patch Set 2 : Fix unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/compiler/js-create-lowering.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M test/unittests/compiler/js-create-lowering-unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
Michael Starzinger
3 years, 11 months ago (2017-01-13 12:26:48 UTC) #1
Jarin
lgtm
3 years, 11 months ago (2017-01-13 14:01:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636493002/20001
3 years, 11 months ago (2017-01-13 14:05:01 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 14:07:09 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/83f19e7d972c9564b523da49782eb41b093...

Powered by Google App Engine
This is Rietveld 408576698