Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2636453005: Follow-up fix to Git module. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 11 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Follow-up fix to Git module. After http://crrev.com/2594513003, the git.changed_files function was broken, which broke webkit-patch pretty-diff. BUG=676012, 680839 Review-Url: https://codereview.chromium.org/2636453005 Cr-Commit-Position: refs/heads/master@{#443824} Committed: https://chromium.googlesource.com/chromium/src/+/d097cd3bbd127ea8168b7d399ab25404b9701b15

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
qyearsley
3 years, 11 months ago (2017-01-13 18:10:54 UTC) #2
tkent
lgtm
3 years, 11 months ago (2017-01-15 23:11:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636453005/1
3 years, 11 months ago (2017-01-15 23:12:14 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 00:20:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d097cd3bbd127ea8168b7d399ab2...

Powered by Google App Engine
This is Rietveld 408576698