Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2636443004: Make rewind work on DBC (Closed)

Created:
3 years, 11 months ago by turnidge
Modified:
3 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : More stuff #

Patch Set 3 : More stuff #

Patch Set 4 : Tweaks #

Total comments: 2

Patch Set 5 : Code Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -72 lines) Patch
M runtime/observatory/tests/service/rewind_optimized_out_test.dart View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/service.status View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/tests/vm/vm.status View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/constants_dbc.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language.cc View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/service.cc View 1 2 3 4 1 chunk +0 lines, -7 lines 0 comments Download
M runtime/vm/simulator_dbc.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/simulator_dbc.cc View 1 2 3 4 4 chunks +74 lines, -52 lines 0 comments Download
M runtime/vm/stub_code_dbc.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
turnidge
3 years, 9 months ago (2017-03-02 19:29:58 UTC) #3
Cutch
LGTM w/c https://codereview.chromium.org/2636443004/diff/60001/runtime/vm/simulator_dbc.cc File runtime/vm/simulator_dbc.cc (right): https://codereview.chromium.org/2636443004/diff/60001/runtime/vm/simulator_dbc.cc#newcode1107 runtime/vm/simulator_dbc.cc:1107: DART_FORCE_INLINE bool Simulator::Deoptimize(Thread* thread, Maybe add a ...
3 years, 9 months ago (2017-03-07 00:22:29 UTC) #4
turnidge
https://codereview.chromium.org/2636443004/diff/60001/runtime/vm/simulator_dbc.cc File runtime/vm/simulator_dbc.cc (right): https://codereview.chromium.org/2636443004/diff/60001/runtime/vm/simulator_dbc.cc#newcode1107 runtime/vm/simulator_dbc.cc:1107: DART_FORCE_INLINE bool Simulator::Deoptimize(Thread* thread, On 2017/03/07 00:22:29, Cutch wrote: ...
3 years, 9 months ago (2017-03-08 19:24:08 UTC) #5
turnidge
3 years, 9 months ago (2017-03-08 21:16:00 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
7d6ba6bf1f4da5317ccac242c0644bc25eefef88 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698