Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Side by Side Diff: runtime/vm/service.cc

Issue 2636443004: Make rewind work on DBC (Closed)
Patch Set: Code Review Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/simulator_dbc.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/service.h" 5 #include "vm/service.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "include/dart_native_api.h" 8 #include "include/dart_native_api.h"
9 #include "platform/globals.h" 9 #include "platform/globals.h"
10 10
(...skipping 3026 matching lines...) Expand 10 before | Expand all | Expand 10 after
3037 new UIntParameter("frameIndex", false), NULL, 3037 new UIntParameter("frameIndex", false), NULL,
3038 }; 3038 };
3039 3039
3040 3040
3041 static bool Resume(Thread* thread, JSONStream* js) { 3041 static bool Resume(Thread* thread, JSONStream* js) {
3042 const char* step_param = js->LookupParam("step"); 3042 const char* step_param = js->LookupParam("step");
3043 Debugger::ResumeAction step = Debugger::kContinue; 3043 Debugger::ResumeAction step = Debugger::kContinue;
3044 if (step_param != NULL) { 3044 if (step_param != NULL) {
3045 step = EnumMapper(step_param, step_enum_names, step_enum_values); 3045 step = EnumMapper(step_param, step_enum_names, step_enum_values);
3046 } 3046 }
3047 #if defined(TARGET_ARCH_DBC)
3048 if (step == Debugger::kStepRewind) {
3049 js->PrintError(kCannotResume,
3050 "Rewind not yet implemented on this architecture");
3051 return true;
3052 }
3053 #endif
3054 intptr_t frame_index = 1; 3047 intptr_t frame_index = 1;
3055 const char* frame_index_param = js->LookupParam("frameIndex"); 3048 const char* frame_index_param = js->LookupParam("frameIndex");
3056 if (frame_index_param != NULL) { 3049 if (frame_index_param != NULL) {
3057 if (step != Debugger::kStepRewind) { 3050 if (step != Debugger::kStepRewind) {
3058 // Only rewind supports the frameIndex parameter. 3051 // Only rewind supports the frameIndex parameter.
3059 js->PrintError( 3052 js->PrintError(
3060 kInvalidParams, 3053 kInvalidParams,
3061 "%s: the 'frameIndex' parameter can only be used when rewinding", 3054 "%s: the 'frameIndex' parameter can only be used when rewinding",
3062 js->method()); 3055 js->method());
3063 return true; 3056 return true;
(...skipping 1119 matching lines...) Expand 10 before | Expand all | Expand 10 after
4183 if (strcmp(method_name, method.name) == 0) { 4176 if (strcmp(method_name, method.name) == 0) {
4184 return &method; 4177 return &method;
4185 } 4178 }
4186 } 4179 }
4187 return NULL; 4180 return NULL;
4188 } 4181 }
4189 4182
4190 #endif // !PRODUCT 4183 #endif // !PRODUCT
4191 4184
4192 } // namespace dart 4185 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language.cc ('k') | runtime/vm/simulator_dbc.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698