Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 26364002: [android] FlagChanger should only require root to set flags for Chrome. (Closed)

Created:
7 years, 2 months ago by craigdh
Modified:
7 years, 2 months ago
Reviewers:
frankf
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org, digit1
Visibility:
Public.

Description

[android] FlagChanger should only require root to set flags for Chrome. BUG=304832 TEST=None NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227795

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : fix bug #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -7 lines) Patch
M build/android/provision_devices.py View 1 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/constants.py View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M build/android/pylib/flag_changer.py View 1 2 1 chunk +17 lines, -4 lines 2 comments Download
M build/android/tombstones.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
craigdh
7 years, 2 months ago (2013-10-07 21:45:51 UTC) #1
frankf
lgtm https://codereview.chromium.org/26364002/diff/1/build/android/pylib/flag_changer.py File build/android/pylib/flag_changer.py (right): https://codereview.chromium.org/26364002/diff/1/build/android/pylib/flag_changer.py#newcode105 build/android/pylib/flag_changer.py:105: self._adb.SetFileContents(self._cmdline_file, cmd_line) as part of API cleanup, you ...
7 years, 2 months ago (2013-10-07 22:09:02 UTC) #2
craigdh
https://codereview.chromium.org/26364002/diff/1/build/android/pylib/flag_changer.py File build/android/pylib/flag_changer.py (right): https://codereview.chromium.org/26364002/diff/1/build/android/pylib/flag_changer.py#newcode111 build/android/pylib/flag_changer.py:111: self._adb.RunShellCommand(prefix + 'rm ' + self._cmdline_file) On 2013/10/07 22:09:03, ...
7 years, 2 months ago (2013-10-07 22:36:27 UTC) #3
frankf
https://codereview.chromium.org/26364002/diff/18001/build/android/pylib/flag_changer.py File build/android/pylib/flag_changer.py (right): https://codereview.chromium.org/26364002/diff/18001/build/android/pylib/flag_changer.py#newcode102 build/android/pylib/flag_changer.py:102: self._adb.SetProtectedFileContents(self._cmdline_file, cmd_line) BTW, why do you need this every ...
7 years, 2 months ago (2013-10-08 23:44:52 UTC) #4
craigdh
https://codereview.chromium.org/26364002/diff/18001/build/android/pylib/flag_changer.py File build/android/pylib/flag_changer.py (right): https://codereview.chromium.org/26364002/diff/18001/build/android/pylib/flag_changer.py#newcode102 build/android/pylib/flag_changer.py:102: self._adb.SetProtectedFileContents(self._cmdline_file, cmd_line) On 2013/10/08 23:44:52, frankf wrote: > BTW, ...
7 years, 2 months ago (2013-10-08 23:53:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/26364002/18001
7 years, 2 months ago (2013-10-09 18:48:30 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-09 20:26:07 UTC) #7
Message was sent while issue was closed. 
Change committed as 227795

Powered by Google App Engine
This is Rietveld 408576698