build/android/provision_devices.py - Issue 26364002: [android] FlagChanger should only require root to set flags for Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/provision_devices.py

Issue 26364002: [android] FlagChanger should only require root to set flags for Chrome. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bug Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/provision_devices.py

diff --git a/build/android/provision_devices.py b/build/android/provision_devices.py

index 1d4e5215157d97a67e9c2672b9cc846444cc605f..a3922469c8e765a221e055635483a6ecf9fc254b 100755

--- a/build/android/provision_devices.py

+++ b/build/android/provision_devices.py

@@ -72,7 +72,7 @@ def ProvisionDevices(options):

devices = android_commands.GetAttachedDevices()

for device in devices:

android_cmd = android_commands.AndroidCommands(device)

- android_cmd.RunShellCommand('su -c date -u %f' % time.time())

+ android_cmd.RunShellCommandWithSU('date -u %f' % time.time())

if options.auto_reconnect:

PushAndLaunchAdbReboot(devices, options.target)

« no previous file with comments | « no previous file | build/android/pylib/constants.py » ('j') | build/android/pylib/flag_changer.py » ('J')