Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2636383002: MD Settings: hide rows (rather than row contents) for some custom toggles in privacy (Closed)

Created:
3 years, 11 months ago by Dan Beam
Modified:
3 years, 11 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: hide rows (rather than row contents) for some custom toggles in privacy R=michaelpg@chromium.org BUG=681491 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2636383002 Cr-Commit-Position: refs/heads/master@{#444370} Committed: https://chromium.googlesource.com/chromium/src/+/2d6d6df8d9dd312483bfda4c6db5d5afcdfc217e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Dan Beam
3 years, 11 months ago (2017-01-18 05:29:25 UTC) #2
michaelpg
lgtm thanks
3 years, 11 months ago (2017-01-18 05:39:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636383002/1
3 years, 11 months ago (2017-01-18 15:39:16 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 15:43:22 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2d6d6df8d9dd312483bfda4c6db5...

Powered by Google App Engine
This is Rietveld 408576698