cc: Fix missing ready to activate/draw callbacks.

cc: Fix missing ready to activate/draw callbacks.

Missing NotifyReadyToActivate/Draw can cause the renderer/browser
compositor to hang. This shows as a ChromeOS hang when overview mode is
toggled continuously and as a renderer hang crash report.

It's possible for TileManager to get into a state where it hits the
raster task limit and the only tiles left after running a set of tasks
are solid color tiles which are required for activate/draw. These solid
color tiles are marked as ready to draw in AssignGpuMemoryToTiles and
therefore ready to activate/draw callbacks aren't scheduled.

It is not known how TileManager gets into this state except that certain
tiling sets are marked as done thereby removing non-solid color tiles
between PrepareTiles and the ready to activate/draw checks.

R=vmpstr@chromium.org
BUG=679970, 622080
TEST=TileManagerTest.AllWorkFinished
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2636323002
Cr-Commit-Position: refs/heads/master@{#444204}
Committed: https://chromium.googlesource.com/chromium/src/+/a8ad82c005ae878c448ae500b3f7b5e3a880ad56

[sunnyps, 2017-01-17 23:29:46]

Description was changed from

==========
cc: Fix missing ready to activate/draw callbacks.

Missing NotifyReadyToActivate/Draw can cause the renderer/browser
compositor to hang. This shows as a ChromeOS hang when overview mode is
toggled continuously and as a renderer hang crash report.

It's possible for TileManager to get into a state where it hits the
raster task limit and the only tiles left after running a set of tasks
are solid color tiles which are required for activate/draw. These solid
color tiles are marked as ready to draw in AssignGpuMemoryToTiles and
therefore ready to activate/draw callbacks aren't scheduled.

It is not known how TileManager gets into this state except that certain
tiling sets are marked as done thereby removing non-solid color tiles
between PrepareTiles and the ready to activate/draw checks.

R=vmpstr@chromium.org
BUG=679970,622080
TEST=TileManagerTest.AllWorkFinished
==========

to

==========
cc: Fix missing ready to activate/draw callbacks.

Missing NotifyReadyToActivate/Draw can cause the renderer/browser
compositor to hang. This shows as a ChromeOS hang when overview mode is
toggled continuously and as a renderer hang crash report.

It's possible for TileManager to get into a state where it hits the
raster task limit and the only tiles left after running a set of tasks
are solid color tiles which are required for activate/draw. These solid
color tiles are marked as ready to draw in AssignGpuMemoryToTiles and
therefore ready to activate/draw callbacks aren't scheduled.

It is not known how TileManager gets into this state except that certain
tiling sets are marked as done thereby removing non-solid color tiles
between PrepareTiles and the ready to activate/draw checks.

R=vmpstr@chromium.org
BUG=679970,622080
TEST=TileManagerTest.AllWorkFinished
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[sunnyps, 2017-01-17 23:30:04]

The CQ bit was checked by sunnyps@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 23:30:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sunnyps, 2017-01-17 23:30:50]

PTAL

I've verified that the test fails with ToT and passes with the patch.

[vmpstr, 2017-01-17 23:37:49]

lgtm

[sunnyps, 2017-01-17 23:41:34]

The CQ bit was unchecked by sunnyps@chromium.org

[sunnyps, 2017-01-17 23:41:38]

The CQ bit was checked by sunnyps@chromium.org

[commit-bot: I haz the power, 2017-01-17 23:42:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 00:34:23]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484696498488390, "parent_rev":
"faaee985121bc612a5a79b03215a490f7f65d0eb", "commit_rev":
"a8ad82c005ae878c448ae500b3f7b5e3a880ad56"}

[commit-bot: I haz the power, 2017-01-18 00:34:55]

Description was changed from

==========
cc: Fix missing ready to activate/draw callbacks.

Missing NotifyReadyToActivate/Draw can cause the renderer/browser
compositor to hang. This shows as a ChromeOS hang when overview mode is
toggled continuously and as a renderer hang crash report.

It's possible for TileManager to get into a state where it hits the
raster task limit and the only tiles left after running a set of tasks
are solid color tiles which are required for activate/draw. These solid
color tiles are marked as ready to draw in AssignGpuMemoryToTiles and
therefore ready to activate/draw callbacks aren't scheduled.

It is not known how TileManager gets into this state except that certain
tiling sets are marked as done thereby removing non-solid color tiles
between PrepareTiles and the ready to activate/draw checks.

R=vmpstr@chromium.org
BUG=679970,622080
TEST=TileManagerTest.AllWorkFinished
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Fix missing ready to activate/draw callbacks.

Missing NotifyReadyToActivate/Draw can cause the renderer/browser
compositor to hang. This shows as a ChromeOS hang when overview mode is
toggled continuously and as a renderer hang crash report.

It's possible for TileManager to get into a state where it hits the
raster task limit and the only tiles left after running a set of tasks
are solid color tiles which are required for activate/draw. These solid
color tiles are marked as ready to draw in AssignGpuMemoryToTiles and
therefore ready to activate/draw callbacks aren't scheduled.

It is not known how TileManager gets into this state except that certain
tiling sets are marked as done thereby removing non-solid color tiles
between PrepareTiles and the ready to activate/draw checks.

R=vmpstr@chromium.org
BUG=679970,622080
TEST=TileManagerTest.AllWorkFinished
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2636323002
Cr-Commit-Position: refs/heads/master@{#444204}
Committed:
https://chromium.googlesource.com/chromium/src/+/a8ad82c005ae878c448ae500b3f7...
==========

[commit-bot: I haz the power, 2017-01-18 00:34:56]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a8ad82c005ae878c448ae500b3f7...