third_party/WebKit/Source/core/layout/LayoutBox.cpp - Issue 2636253002: Handle nested position:sticky elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2636253002: Handle nested position:sticky elements (Closed)

Patch Set: Ignore position:sticky offsets when computing localToAncestorQuad offsets Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

index 24e8029cd76195d5c3b2fcb13c43c455ff6dd9f9..0c1895308b7d232dba2edba2f3cdcd99d201caa0 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp

@@ -2005,12 +2005,13 @@ void LayoutBox::mapAncestorToLocal(const LayoutBoxModelObject* ancestor,

LayoutBoxModelObject::mapAncestorToLocal(ancestor, transformState, mode);

}

-LayoutSize LayoutBox::offsetFromContainer(const LayoutObject* o) const {

+LayoutSize LayoutBox::offsetFromContainer(const LayoutObject* o,

+ bool ignoreSticky) const {

ASSERT(o == container());

LayoutSize offset;

if (isInFlowPositioned())

- offset += offsetForInFlowPosition();

+ offset += offsetForInFlowPosition(ignoreSticky);

offset += physicalLocationOffset();