Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2636253002: Handle nested position:sticky elements (Closed)
Patch Set: Ignore position:sticky offsets when computing localToAncestorQuad offsets Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc.
7 * All rights reserved. 7 * All rights reserved.
8 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved. 8 * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1987 matching lines...) Expand 10 before | Expand all | Expand 10 after
1998 // container for fixed descendants, and may itself also be fixed position. So 1998 // container for fixed descendants, and may itself also be fixed position. So
1999 // propagate 'fixed' up only if this box is fixed position. 1999 // propagate 'fixed' up only if this box is fixed position.
2000 if (style()->canContainFixedPositionObjects() && !isFixedPos) 2000 if (style()->canContainFixedPositionObjects() && !isFixedPos)
2001 mode &= ~IsFixed; 2001 mode &= ~IsFixed;
2002 else if (isFixedPos) 2002 else if (isFixedPos)
2003 mode |= IsFixed; 2003 mode |= IsFixed;
2004 2004
2005 LayoutBoxModelObject::mapAncestorToLocal(ancestor, transformState, mode); 2005 LayoutBoxModelObject::mapAncestorToLocal(ancestor, transformState, mode);
2006 } 2006 }
2007 2007
2008 LayoutSize LayoutBox::offsetFromContainer(const LayoutObject* o) const { 2008 LayoutSize LayoutBox::offsetFromContainer(const LayoutObject* o,
2009 bool ignoreSticky) const {
2009 ASSERT(o == container()); 2010 ASSERT(o == container());
2010 2011
2011 LayoutSize offset; 2012 LayoutSize offset;
2012 if (isInFlowPositioned()) 2013 if (isInFlowPositioned())
2013 offset += offsetForInFlowPosition(); 2014 offset += offsetForInFlowPosition(ignoreSticky);
2014 2015
2015 offset += physicalLocationOffset(); 2016 offset += physicalLocationOffset();
2016 2017
2017 if (o->hasOverflowClip()) 2018 if (o->hasOverflowClip())
2018 offset -= toLayoutBox(o)->scrolledContentOffset(); 2019 offset -= toLayoutBox(o)->scrolledContentOffset();
2019 2020
2020 if (style()->position() == AbsolutePosition && o->isInFlowPositioned() && 2021 if (style()->position() == AbsolutePosition && o->isInFlowPositioned() &&
2021 o->isLayoutInline()) 2022 o->isLayoutInline())
2022 offset += toLayoutInline(o)->offsetForInFlowPositionedInline(*this); 2023 offset += toLayoutInline(o)->offsetForInFlowPositionedInline(*this);
2023 2024
(...skipping 3670 matching lines...) Expand 10 before | Expand all | Expand 10 after
5694 block->adjustChildDebugRect(rect); 5695 block->adjustChildDebugRect(rect);
5695 5696
5696 return rect; 5697 return rect;
5697 } 5698 }
5698 5699
5699 bool LayoutBox::shouldClipOverflow() const { 5700 bool LayoutBox::shouldClipOverflow() const {
5700 return hasOverflowClip() || styleRef().containsPaint() || hasControlClip(); 5701 return hasOverflowClip() || styleRef().containsPaint() || hasControlClip();
5701 } 5702 }
5702 5703
5703 } // namespace blink 5704 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698