Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2636183004:
Convert ChromeOmniboxNavigationObserver to use the new navigation callbacks. (Closed)
|
Created:
3 years, 11 months ago by jam Modified:
3 years, 11 months ago Reviewers:
Peter Kasting CC:
chromium-reviews, jdonnelly+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionConvert ChromeOmniboxNavigationObserver to use the new navigation callbacks.
BUG=682002
Review-Url: https://codereview.chromium.org/2636183004
Cr-Commit-Position: refs/heads/master@{#445599}
Committed: https://chromium.googlesource.com/chromium/src/+/824295e06184bab209d43d663b49fdf39cb887d5
Patch Set 1 #Patch Set 2 : closer to original #
Total comments: 3
Messages
Total messages: 24 (18 generated)
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Description was changed from ========== Convert ChromeOmniboxNavigationObserver to use the new navigation callbacks. BUG=682002 ========== to ========== Convert ChromeOmniboxNavigationObserver to use the new navigation callbacks. BUG=682002 ==========
jam@chromium.org changed reviewers: + pkasting@chromium.org
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM https://codereview.chromium.org/2636183004/diff/40001/chrome/browser/ui/omnib... File chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.cc (right): https://codereview.chromium.org/2636183004/diff/40001/chrome/browser/ui/omnib... chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.cc:146: navigation_handle->IsErrorPage() && Does IsErrorPage() mean the same thing that "failed the provisional load" used to mean? I'm worried about load failures that wouldn't result in error pages.
https://codereview.chromium.org/2636183004/diff/40001/chrome/browser/ui/omnib... File chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.cc (right): https://codereview.chromium.org/2636183004/diff/40001/chrome/browser/ui/omnib... chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.cc:146: navigation_handle->IsErrorPage() && On 2017/01/24 00:15:31, Peter Kasting wrote: > Does IsErrorPage() mean the same thing that "failed the provisional load" used > to mean? I'm worried about load failures that wouldn't result in error pages. Yep should be. A failing provisional load is equivalent to a navigation finishing with an error.
https://codereview.chromium.org/2636183004/diff/40001/chrome/browser/ui/omnib... File chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.cc (right): https://codereview.chromium.org/2636183004/diff/40001/chrome/browser/ui/omnib... chrome/browser/ui/omnibox/chrome_omnibox_navigation_observer.cc:146: navigation_handle->IsErrorPage() && On 2017/01/24 00:21:51, jam wrote: > On 2017/01/24 00:15:31, Peter Kasting wrote: > > Does IsErrorPage() mean the same thing that "failed the provisional load" used > > to mean? I'm worried about load failures that wouldn't result in error pages. > > Yep should be. A failing provisional load is equivalent to a navigation > finishing with an error. but if you have any test cases that aren't in existing tests, I'm happy to manually test as well.
The CQ bit was checked by jam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485217351837570,
"parent_rev": "c0263b1992722899b52384aedc940d76a74d1a6c", "commit_rev":
"824295e06184bab209d43d663b49fdf39cb887d5"}
Message was sent while issue was closed.
Description was changed from ========== Convert ChromeOmniboxNavigationObserver to use the new navigation callbacks. BUG=682002 ========== to ========== Convert ChromeOmniboxNavigationObserver to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2636183004 Cr-Commit-Position: refs/heads/master@{#445599} Committed: https://chromium.googlesource.com/chromium/src/+/824295e06184bab209d43d663b49... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/824295e06184bab209d43d663b49... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
