Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 2636143002: [builtins] CompileLazy bailed out to the runtime entirely too often. (Closed)

Created:
3 years, 11 months ago by mvstanton
Modified:
3 years, 11 months ago
Reviewers:
Leszek Swirski
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] CompileLazy bailed out to the runtime entirely too often. This is just a bug. CompileLazy knows how to look in the SharedFunctionInfo for code (or bytecode, essentially) if it finds nothing in the OptimizedCodeMap. Ensure that behavior. BUG=681543 R=leszeks@chromium.org Review-Url: https://codereview.chromium.org/2636143002 Cr-Commit-Position: refs/heads/master@{#42409} Committed: https://chromium.googlesource.com/v8/v8/+/743fdb25b3f4dd11303a5f3507dcc9578e7417e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -24 lines) Patch
M src/builtins/arm/builtins-arm.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (7 generated)
mvstanton
HI Leszek, could you have a look at this CL? Thanks! --Michael
3 years, 11 months ago (2017-01-17 13:17:26 UTC) #5
Leszek Swirski
Great catch. Looks like there's a few ports missing (ppc, s390, x87), LGTM otherwise.
3 years, 11 months ago (2017-01-17 13:25:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636143002/1
3 years, 11 months ago (2017-01-17 13:52:54 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 13:54:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/743fdb25b3f4dd11303a5f3507dcc9578e7...

Powered by Google App Engine
This is Rietveld 408576698