Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Issue 2636113002: Change base::DictionaryValue mojo deserialization to not expand paths. (Closed)

Created:
3 years, 11 months ago by Sam McNally
Modified:
3 years, 11 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change base::DictionaryValue mojo deserialization to not expand paths. Currently, when deserializing a base::DictionaryValue from mojo, the values in the dictionary are set with Set(), which expands paths. This causes data to be mutated when round-tripping through mojo. This CL changes it to use SetWithoutPathExpansion() to avoid this mutation. BUG=675860 Review-Url: https://codereview.chromium.org/2636113002 Cr-Commit-Position: refs/heads/master@{#444169} Committed: https://chromium.googlesource.com/chromium/src/+/e1b6d38fd369d03ac2f13349a9d329ff0a8943d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M mojo/common/common_custom_types_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/common/values_struct_traits.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Sam McNally
+rockot for //mojo +dcheng for struct traits
3 years, 11 months ago (2017-01-17 03:31:38 UTC) #7
dcheng
lgtm
3 years, 11 months ago (2017-01-17 06:55:35 UTC) #8
Ken Rockot(use gerrit already)
lgtm
3 years, 11 months ago (2017-01-17 17:59:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636113002/1
3 years, 11 months ago (2017-01-17 22:34:52 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 22:40:43 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e1b6d38fd369d03ac2f13349a9d3...

Powered by Google App Engine
This is Rietveld 408576698