Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2636083002: WTF: Put String::show()'s definition into the WTF namespace. (Closed)

Created:
3 years, 11 months ago by danakj
Modified:
3 years, 11 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WTF: Put String::show()'s definition into the WTF namespace. The rename tool doesn't see it otherwise. Also cleanup a bit and drop some old functions in here meant to be called from gdb, and move the asciiDebug helper into an anonymous namespace inside WTF so that the rename tool also renames it. BUG=598176 Review-Url: https://codereview.chromium.org/2636083002 Cr-Commit-Position: refs/heads/master@{#443964} Committed: https://chromium.googlesource.com/chromium/src/+/a2377c097a1fa051f90f9c02d96d010073fcb701

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -38 lines) Patch
M third_party/WebKit/Source/wtf/text/WTFString.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.cpp View 2 chunks +27 lines, -38 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
danakj
3 years, 11 months ago (2017-01-16 23:36:55 UTC) #4
danakj
Some extra notes on history on the bug.
3 years, 11 months ago (2017-01-16 23:37:06 UTC) #5
haraken
LGTM
3 years, 11 months ago (2017-01-16 23:40:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636083002/1
3 years, 11 months ago (2017-01-16 23:51:51 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 01:23:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a2377c097a1fa051f90f9c02d96d...

Powered by Google App Engine
This is Rietveld 408576698