WTF: Put String::show()'s definition into the WTF namespace.

WTF: Put String::show()'s definition into the WTF namespace.

The rename tool doesn't see it otherwise. Also cleanup a bit and drop
some old functions in here meant to be called from gdb, and move the
asciiDebug helper into an anonymous namespace inside WTF so that the
rename tool also renames it.

BUG=598176
Review-Url: https://codereview.chromium.org/2636083002
Cr-Commit-Position: refs/heads/master@{#443964}
Committed: https://chromium.googlesource.com/chromium/src/+/a2377c097a1fa051f90f9c02d96d010073fcb701

[danakj, 2017-01-16 23:36:35]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 23:36:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danakj, 2017-01-16 23:36:54]

danakj@chromium.org changed reviewers:
+ haraken@chromium.org

[danakj, 2017-01-16 23:37:06]

Some extra notes on history on the bug.

[haraken, 2017-01-16 23:40:48]

LGTM

[danakj, 2017-01-16 23:51:23]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2017-01-16 23:51:32]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2017-01-16 23:51:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 01:21:58]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484610692236610, "parent_rev":
"62fd0c1ec30ee121aa0720d8d7d390cc7e9ba226", "commit_rev":
"a2377c097a1fa051f90f9c02d96d010073fcb701"}

[commit-bot: I haz the power, 2017-01-17 01:23:37]

Description was changed from

==========
WTF: Put String::show()'s definition into the WTF namespace.

The rename tool doesn't see it otherwise. Also cleanup a bit and drop
some old functions in here meant to be called from gdb, and move the
asciiDebug helper into an anonymous namespace inside WTF so that the
rename tool also renames it.

BUG=598176
==========

to

==========
WTF: Put String::show()'s definition into the WTF namespace.

The rename tool doesn't see it otherwise. Also cleanup a bit and drop
some old functions in here meant to be called from gdb, and move the
asciiDebug helper into an anonymous namespace inside WTF so that the
rename tool also renames it.

BUG=598176

Review-Url: https://codereview.chromium.org/2636083002
Cr-Commit-Position: refs/heads/master@{#443964}
Committed:
https://chromium.googlesource.com/chromium/src/+/a2377c097a1fa051f90f9c02d96d...
==========

[commit-bot: I haz the power, 2017-01-17 01:23:38]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a2377c097a1fa051f90f9c02d96d...