Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Unified Diff: ui/display/mojo/display_mode_mojo.h

Issue 2636073002: Create mojom and StructTraits for ui/display/types/display_mode.cc (Closed)
Patch Set: Dont need to make changes in ui/ozone/common/BUILD.gn. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/display/mojo/display_mode_mojo.h
diff --git a/ui/display/mojo/display_mode_mojo.h b/ui/display/mojo/display_mode_mojo.h
new file mode 100644
index 0000000000000000000000000000000000000000..42036ee5700cba991ac95cbb3e10265397cd5400
--- /dev/null
+++ b/ui/display/mojo/display_mode_mojo.h
@@ -0,0 +1,24 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_DISPLAY_TYPES_MOJO_DISPLAY_MODE_MOJO_H_
kylechar 2017/01/24 21:15:07 UI_DISPLAY_DISPLAY_MODE_MOJO_H_
thanhph1 2017/01/25 16:26:17 Done.
+#define UI_DISPLAY_TYPES_MOJO_DISPLAY_MODE_MOJO_H_
+
+#include "ui/display/display_export.h"
+#include "ui/display/types/display_mode.h"
+
+namespace display {
+
+//Move-only class.
kylechar 2017/01/24 21:15:07 This comment isn't helpful. It would be better to
thanhph1 2017/01/25 16:26:17 Done.
+class DISPLAY_EXPORT DisplayModeMojo: public DisplayMode {
+ public:
kylechar 2017/01/24 21:15:07 You will also need a constructor that lets you set
thanhph1 2017/01/25 16:26:17 Done.
+ DisplayModeMojo();
+ ~DisplayModeMojo() override;
+ DisplayModeMojo(DisplayModeMojo &&) = default;
kylechar 2017/01/24 21:15:07 Move to cc file.
thanhph1 2017/01/25 16:26:17 Done.
+ DisplayModeMojo& operator=(DisplayModeMojo &&) = default;
kylechar 2017/01/24 21:15:07 Move to cc file.
+};
kylechar 2017/01/24 21:15:07 Missing DISALLOW_COPY_AND_ASSIGN.
+
+} // namespace
+
+#endif // UI_DISPLAY_TYPES_MOJO_DISPLAY_MODE_MOJO_H_

Powered by Google App Engine
This is Rietveld 408576698