ui/display/mojo/display_mode_mojo.h - Issue 2636073002: Create mojom and StructTraits for ui/display/types/display_mode.cc

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/display/mojo/display_mode_mojo.h

Issue 2636073002: Create mojom and StructTraits for ui/display/types/display_mode.cc (Closed)

Patch Set: Dont need to make changes in ui/ozone/common/BUILD.gn. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef UI_DISPLAY_TYPES_MOJO_DISPLAY_MODE_MOJO_H_
	kylechar 2017/01/24 21:15:07 UI_DISPLAY_DISPLAY_MODE_MOJO_H_ UI_DISPLAY_DISPLAY_MODE_MOJO_H_ thanhph1 2017/01/25 16:26:17 Done. Show quoted text On 2017/01/24 21:15:07, kylechar wrote: > UI_DISPLAY_DISPLAY_MODE_MOJO_H_ Done.
	6 #define UI_DISPLAY_TYPES_MOJO_DISPLAY_MODE_MOJO_H_

	7

	8 #include "ui/display/display_export.h"

	9 #include "ui/display/types/display_mode.h"

	10

	11 namespace display {

	12

	13 //Move-only class.
	kylechar 2017/01/24 21:15:07 This comment isn't helpful. It would be better to This comment isn't helpful. It would be better to explain why this implementation of DisplayMode exists. thanhph1 2017/01/25 16:26:17 Done. Show quoted text On 2017/01/24 21:15:07, kylechar wrote: > This comment isn't helpful. It would be better to explain why this > implementation of DisplayMode exists. Done.
	14 class DISPLAY_EXPORT DisplayModeMojo: public DisplayMode {

	15 public:
	kylechar 2017/01/24 21:15:07 You will also need a constructor that lets you set You will also need a constructor that lets you set size, is_interlaced and refresh_rate. thanhph1 2017/01/25 16:26:17 Done. Show quoted text On 2017/01/24 21:15:07, kylechar wrote: > You will also need a constructor that lets you set size, is_interlaced and > refresh_rate. Done.
	16 DisplayModeMojo();

	17 ~DisplayModeMojo() override;

	18 DisplayModeMojo(DisplayModeMojo &&) = default;
	kylechar 2017/01/24 21:15:07 Move to cc file. Move to cc file. thanhph1 2017/01/25 16:26:17 Done. Show quoted text On 2017/01/24 21:15:07, kylechar wrote: > Move to cc file. Done.
	19 DisplayModeMojo& operator=(DisplayModeMojo &&) = default;
	kylechar 2017/01/24 21:15:07 Move to cc file. Move to cc file.
	20 };
	kylechar 2017/01/24 21:15:07 Missing DISALLOW_COPY_AND_ASSIGN. Missing DISALLOW_COPY_AND_ASSIGN.
	21

	22 } // namespace

	23

	24 #endif // UI_DISPLAY_TYPES_MOJO_DISPLAY_MODE_MOJO_H_

OLD	NEW

« ui/display/mojo/BUILD.gn ('K') | « ui/display/mojo/OWNERS ('k') | ui/display/mojo/display_mode_mojo.cc » ('j') | ui/display/mojo/display_mode_mojo.cc » ('J')