DescriptionRevert of [EditCommandSource] Pass source to |CompositEditCommand| and |TypingCommand| (3/3) (patchset #1 id:20001 of https://codereview.chromium.org/2579253002/ )
Reason for revert:
We want to revert all CLs and start over the refactor process, see:
https://crbug.com/673789.
Original issue's description:
> [EditCommandSource] Pass source to |CompositEditCommand| and |TypingCommand| (3/3)
>
> This is the last sub-patch (3/3) of supporting |EditCommandSource| in
> |CompositeEditCommand| (https://crrev.com/2574793002).
>
> Instead of adding |EditCommandSource| to constructor, this CL:
> 1. Pass source to |CompositeEditCommand::apply(EditCommandSource)|
> 2. Pass source to various static methods of |TypingCommand|
>
> We don't have to store command source as attribute because we only need it to fire
> 'beforeinput' in the above locations.
> This approach also helped avoiding modifying all the |CompositeEditCommand|
> constructors.
>
> This CL shouldn't have any behavior change.
>
> To help reviewing, here is a simple doc describing the following plans:
> https://docs.google.com/a/chromium.org/document/d/1M9bQaLKdRpR1qJ9i7zZKN-hKwd4ZkgJs5GPde2ZsDy0/edit?usp=sharing
>
> BUG=673789
>
> Committed: https://crrev.com/acce62cb77947bf2f14d6c7ac74219d515a94ffb
> Cr-Commit-Position: refs/heads/master@{#439130}
TBR=tkent@chromium.org,xiaochengh@chromium.org,yosin@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=673789
Review-Url: https://codereview.chromium.org/2636043002
Cr-Commit-Position: refs/heads/master@{#443960}
Committed: https://chromium.googlesource.com/chromium/src/+/e2dafbf4760e826f18b0c16b3976a667fcacf8a0
Patch Set 1 #Patch Set 2 : Remove command source in ApplyStyleCommandTest.cpp #Messages
Total messages: 12 (6 generated)
|