Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 2636043002: Revert of [EditCommandSource] Pass source to |CompositEditCommand| and |TypingCommand| (3/3) (Closed)

Created:
3 years, 11 months ago by chongz
Modified:
3 years, 11 months ago
Reviewers:
tkent, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [EditCommandSource] Pass source to |CompositEditCommand| and |TypingCommand| (3/3) (patchset #1 id:20001 of https://codereview.chromium.org/2579253002/ ) Reason for revert: We want to revert all CLs and start over the refactor process, see: https://crbug.com/673789. Original issue's description: > [EditCommandSource] Pass source to |CompositEditCommand| and |TypingCommand| (3/3) > > This is the last sub-patch (3/3) of supporting |EditCommandSource| in > |CompositeEditCommand| (https://crrev.com/2574793002). > > Instead of adding |EditCommandSource| to constructor, this CL: > 1. Pass source to |CompositeEditCommand::apply(EditCommandSource)| > 2. Pass source to various static methods of |TypingCommand| > > We don't have to store command source as attribute because we only need it to fire > 'beforeinput' in the above locations. > This approach also helped avoiding modifying all the |CompositeEditCommand| > constructors. > > This CL shouldn't have any behavior change. > > To help reviewing, here is a simple doc describing the following plans: > https://docs.google.com/a/chromium.org/document/d/1M9bQaLKdRpR1qJ9i7zZKN-hKwd4ZkgJs5GPde2ZsDy0/edit?usp=sharing > > BUG=673789 > > Committed: https://crrev.com/acce62cb77947bf2f14d6c7ac74219d515a94ffb > Cr-Commit-Position: refs/heads/master@{#439130} TBR=tkent@chromium.org,xiaochengh@chromium.org,yosin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=673789 Review-Url: https://codereview.chromium.org/2636043002 Cr-Commit-Position: refs/heads/master@{#443960} Committed: https://chromium.googlesource.com/chromium/src/+/e2dafbf4760e826f18b0c16b3976a667fcacf8a0

Patch Set 1 #

Patch Set 2 : Remove command source in ApplyStyleCommandTest.cpp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -117 lines) Patch
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 15 chunks +23 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 1 6 chunks +7 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyBlockElementCommandTest.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyStyleCommandTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommandTest.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 1 12 chunks +27 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertListCommandTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommandTest.cpp View 1 3 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.h View 1 1 chunk +4 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp View 1 12 chunks +12 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/TypingCommandTest.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
chongz
Created Revert of [EditCommandSource] Pass source to |CompositEditCommand| and |TypingCommand| (3/3)
3 years, 11 months ago (2017-01-16 21:11:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636043002/1
3 years, 11 months ago (2017-01-16 21:12:34 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/222860)
3 years, 11 months ago (2017-01-16 21:29:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636043002/270001
3 years, 11 months ago (2017-01-16 22:11:53 UTC) #8
tkent
lgtm
3 years, 11 months ago (2017-01-16 22:53:53 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 23:29:07 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:270001) as
https://chromium.googlesource.com/chromium/src/+/e2dafbf4760e826f18b0c16b3976...

Powered by Google App Engine
This is Rietveld 408576698