Add PropertyConverter support for non-zero default primitive values.

Add PropertyConverter support for non-zero default primitive values.

Add non-zero PropertyConverterTest default primitive values.
(the revised test fails without the fix in this CL)

BUG=681233
TEST=Automated; further mash work relies on this functionality.
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2635983005
Cr-Commit-Position: refs/heads/master@{#444462}
Committed: https://chromium.googlesource.com/chromium/src/+/78697424ef7db4e0c3cdc55b2b628a460a063140

[msw, 2017-01-18 01:27:10]

Hey Scott, please take a look; thanks!

[msw, 2017-01-18 01:27:15]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 01:27:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 02:10:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 02:10:13]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sky, 2017-01-18 04:03:10]

I'm curious why you converted to use at() vs []. Other than that, LGTM

https://codereview.chromium.org/2635983005/diff/1/ui/aura/mus/property_conver...
File ui/aura/mus/property_converter.cc (right):

https://codereview.chromium.org/2635983005/diff/1/ui/aura/mus/property_conver...
ui/aura/mus/property_converter.cc:106: PrimitiveType default_value =
primitive_properties_.at(key).default_value;
primitive_properties_[key].default_value?

https://codereview.chromium.org/2635983005/diff/1/ui/aura/mus/property_conver...
ui/aura/mus/property_converter.cc:116: return
primitive_properties_.at(key).transport_name;
Same comment about using [].

[msw, 2017-01-18 16:48:27]

On 2017/01/18 04:03:10, sky wrote:
> I'm curious why you converted to use at() vs []. Other than that, LGTM

Using brackets requires a PrimitiveProperty copy and default ctor, do you prefer
that?

[sky, 2017-01-18 17:27:02]

On 2017/01/18 16:48:27, msw wrote:
> On 2017/01/18 04:03:10, sky wrote:
> > I'm curious why you converted to use at() vs []. Other than that, LGTM
> 
> Using brackets requires a PrimitiveProperty copy and default ctor, do you
prefer
> that?

That's fine by me. I think you can use the default implementation for both,
right?

[msw, 2017-01-18 18:00:41]

On 2017/01/18 17:27:02, sky wrote:
> On 2017/01/18 16:48:27, msw wrote:
> > On 2017/01/18 04:03:10, sky wrote:
> > > I'm curious why you converted to use at() vs []. Other than that, LGTM
> > 
> > Using brackets requires a PrimitiveProperty copy and default ctor, do you
> prefer
> > that?
> 
> That's fine by me. I think you can use the default implementation for both,
> right?

Done, just needed to add a default ctor with =default, I also made the primitive
RegisterProperty function inlined in the header use the brackets accessor.

https://codereview.chromium.org/2635983005/diff/1/ui/aura/mus/property_conver...
File ui/aura/mus/property_converter.cc (right):

https://codereview.chromium.org/2635983005/diff/1/ui/aura/mus/property_conver...
ui/aura/mus/property_converter.cc:106: PrimitiveType default_value =
primitive_properties_.at(key).default_value;
On 2017/01/18 04:03:09, sky wrote:
> primitive_properties_[key].default_value?

Done.

https://codereview.chromium.org/2635983005/diff/1/ui/aura/mus/property_conver...
ui/aura/mus/property_converter.cc:116: return
primitive_properties_.at(key).transport_name;
On 2017/01/18 04:03:09, sky wrote:
> Same comment about using [].

Done.

[msw, 2017-01-18 18:00:48]

The CQ bit was checked by msw@chromium.org

[msw, 2017-01-18 18:00:48]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2635983005/#ps20001
(title: "Address comments.")

[commit-bot: I haz the power, 2017-01-18 18:01:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-01-18 18:28:27]

LGTM

[commit-bot: I haz the power, 2017-01-18 19:08:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 19:08:05]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[msw, 2017-01-18 19:34:33]

The CQ bit was checked by msw@chromium.org

[msw, 2017-01-18 19:34:34]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2635983005/#ps40001
(title: "Revise PrimitiveProperty struct to try fixing Windows link.")

[commit-bot: I haz the power, 2017-01-18 19:35:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 20:30:36]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484768073722020,
"parent_rev": "45fb6bcf301730de030255fdfae7fbe745e5399e", "commit_rev":
"78697424ef7db4e0c3cdc55b2b628a460a063140"}

[commit-bot: I haz the power, 2017-01-18 20:31:15]

Description was changed from

==========
Add PropertyConverter support for non-zero default primitive values.

Add non-zero PropertyConverterTest default primitive values.
(the revised test fails without the fix in this CL)

BUG=681233
TEST=Automated; further mash work relies on this functionality.
R=sky@chromium.org
==========

to

==========
Add PropertyConverter support for non-zero default primitive values.

Add non-zero PropertyConverterTest default primitive values.
(the revised test fails without the fix in this CL)

BUG=681233
TEST=Automated; further mash work relies on this functionality.
R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2635983005
Cr-Commit-Position: refs/heads/master@{#444462}
Committed:
https://chromium.googlesource.com/chromium/src/+/78697424ef7db4e0c3cdc55b2b62...
==========

[commit-bot: I haz the power, 2017-01-18 20:31:16]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/78697424ef7db4e0c3cdc55b2b62...