Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2635983002: Revert of EarlGrey tests for Payment Request (base CL) (Closed)

Created:
3 years, 11 months ago by lpromero
Modified:
3 years, 10 months ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of EarlGrey tests for Payment Request (base CL) (patchset #5 id:120001 of https://codereview.chromium.org/2588913002/ ) Reason for revert: This broke several ExternalURLSSLTestCase downstream with this DCHECK: [0116/083204.532380:FATAL:payment_request_manager.mm(206)] Check failed: _webStateEnabled. Original issue's description: > EarlGrey tests for Payment Request (base CL) > > BUG=602666 > > Review-Url: https://codereview.chromium.org/2588913002 > Cr-Commit-Position: refs/heads/master@{#443319} > Committed: https://chromium.googlesource.com/chromium/src/+/07f18d68d972f8e49c93c699ff61f774fc0584ff TBR=jdonnelly@chromium.org,rohitrao@chromium.org,eugenebut@chromium.org,marq@chromium.org,sdefresne@chromium.org,mahmadi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=602666

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
lpromero
Created Revert of EarlGrey tests for Payment Request (base CL)
3 years, 11 months ago (2017-01-16 17:47:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2635983002/1
3 years, 11 months ago (2017-01-16 17:47:32 UTC) #3
lpromero
This could not be the root issue. Investigating.
3 years, 11 months ago (2017-01-16 18:07:49 UTC) #5
marq (ping after 24h)
On 2017/01/16 18:07:49, lpromero (ooo til Feb9) wrote: > This could not be the root ...
3 years, 10 months ago (2017-01-27 12:54:04 UTC) #6
lpromero
3 years, 10 months ago (2017-02-13 09:35:55 UTC) #8
Message was sent while issue was closed.
Closing without landing.

Powered by Google App Engine
This is Rietveld 408576698